Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 2536143003: Support --strong when running dartk from test.py. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 0a15772ece9feb1b497662e8793acc082ccaf0ab..f0f8bc71c13b6bd3284ad13b9bf73a98e507bab4 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -94,7 +94,8 @@ abstract class CompilerConfiguration {
return ComposedCompilerConfiguration.createDartKConfiguration(
isHostChecked: isHostChecked,
useSdk: useSdk,
- verify: verifyKernel);
+ verify: verifyKernel,
+ strong: isStrong);
case 'dartkp':
return ComposedCompilerConfiguration.createDartKPConfiguration(
isHostChecked: isHostChecked,
@@ -102,7 +103,8 @@ abstract class CompilerConfiguration {
useBlobs: useBlobs,
isAndroid: configuration['system'] == 'android',
useSdk: useSdk,
- verify: verifyKernel);
+ verify: verifyKernel,
+ strong: isStrong);
case 'none':
return new NoneCompilerConfiguration(
isDebug: isDebug,
@@ -215,9 +217,10 @@ class NoneCompilerConfiguration extends CompilerConfiguration {
/// The "dartk" compiler.
class DartKCompilerConfiguration extends CompilerConfiguration {
- final bool verify;
+ final bool verify, strong;
- DartKCompilerConfiguration({bool isHostChecked, bool useSdk, this.verify})
+ DartKCompilerConfiguration({bool isHostChecked, bool useSdk, this.verify,
+ this.strong})
: super._subclass(isHostChecked: isHostChecked, useSdk: useSdk);
@override
@@ -236,6 +239,7 @@ class DartKCompilerConfiguration extends CompilerConfiguration {
'$buildDir/patched_sdk',
'--link',
'--target=vm',
+ strong ? '--strong' : null,
verify ? '--verify-ir' : null,
'--out',
outputFileName
@@ -367,13 +371,13 @@ class ComposedCompilerConfiguration extends CompilerConfiguration {
static ComposedCompilerConfiguration createDartKPConfiguration(
{bool isHostChecked, String arch, bool useBlobs, bool isAndroid,
- bool useSdk, bool verify}) {
+ bool useSdk, bool verify, bool strong}) {
var nested = [];
// Compile with dartk.
nested.add(new PipelineCommand.runWithGlobalArguments(
new DartKCompilerConfiguration(isHostChecked: isHostChecked,
- useSdk: useSdk, verify: verify)));
+ useSdk: useSdk, verify: verify, strong: strong)));
// Run the normal precompiler.
nested.add(new PipelineCommand.runWithPreviousKernelOutput(
@@ -384,13 +388,13 @@ class ComposedCompilerConfiguration extends CompilerConfiguration {
}
static ComposedCompilerConfiguration createDartKConfiguration(
- {bool isHostChecked, bool useSdk, bool verify}) {
+ {bool isHostChecked, bool useSdk, bool verify, bool strong}) {
var nested = [];
// Compile with dartk.
nested.add(new PipelineCommand.runWithGlobalArguments(
new DartKCompilerConfiguration(isHostChecked: isHostChecked,
- useSdk: useSdk, verify: verify)));
+ useSdk: useSdk, verify: verify, strong: strong)));
return new ComposedCompilerConfiguration(nested, isPrecompiler: false);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698