Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 253613002: Instrumented libraries: pass MSan, TSan blacklists when building. (Closed)

Created:
6 years, 8 months ago by earthdok
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Instrumented libraries: pass MSan, TSan blacklists when building. Also, use this to blacklist a function which is crashing due to an MSan bug. Also, fix a small issue in DESTDIR builds which I discovered while testing this. BUG=313751 R=glider@chromium.org NOTRY=true TEST=msan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266194

Patch Set 1 #

Patch Set 2 : minor fixes #

Patch Set 3 : fix incorrect default #

Patch Set 4 : use "cp -f" in destdir builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M third_party/instrumented_libraries/download_build_install.py View 1 2 3 3 chunks +16 lines, -6 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/instrumented_libraries/standard_instrumented_library_target.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tools/msan/blacklist.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
earthdok
ptal
6 years, 8 months ago (2014-04-25 14:17:33 UTC) #1
Alexander Potapenko
LGTM
6 years, 8 months ago (2014-04-25 14:35:06 UTC) #2
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 8 months ago (2014-04-25 14:48:29 UTC) #3
earthdok
The CQ bit was unchecked by earthdok@chromium.org
6 years, 8 months ago (2014-04-25 15:25:29 UTC) #4
earthdok
6 years, 8 months ago (2014-04-25 15:27:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r266194 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698