Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2536113003: chromeos: Make InputEventsBlocker NOTIMPLEMENTED for mash (Closed)

Created:
4 years ago by James Cook
Modified:
4 years ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Make InputEventsBlocker NOTIMPLEMENTED for mash This avoids a couple places in login/OOBE that crash under mash. BUG=648764 TEST=manual, start --mash --login-manager Committed: https://crrev.com/f8ce9a7a8bd9e9ccf8a661a051c8fc3055323396 Cr-Commit-Position: refs/heads/master@{#435297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/ui/input_events_blocker.cc View 1 chunk +15 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
James Cook
xiyuan, please take a look. (The one that was causing the problem was in https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/ui/login_display_host_impl.cc?q=inputeventsblocker&sq=package:chromium&l=207&dr=C ...
4 years ago (2016-11-29 22:22:47 UTC) #4
xiyuan
lgtm
4 years ago (2016-11-29 22:25:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536113003/1
4 years ago (2016-11-29 22:33:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-30 00:24:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536113003/1
4 years ago (2016-11-30 16:56:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 17:00:43 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-30 17:05:06 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8ce9a7a8bd9e9ccf8a661a051c8fc3055323396
Cr-Commit-Position: refs/heads/master@{#435297}

Powered by Google App Engine
This is Rietveld 408576698