Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2536093004: update chromium clang docs (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Reviewers:
hans
CC:
chromium-reviews, Reid Kleckner, ruiu, pcc1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

update chromium clang docs - remove references to gyp - remove line implying that lld only works on win (it works on linux too) BUG= Committed: https://crrev.com/2a46c2d1e1e2c7f34ef28c9cdde244e7d267f11f Cr-Commit-Position: refs/heads/master@{#435098}

Patch Set 1 #

Total comments: 2

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -35 lines) Patch
M docs/clang.md View 1 5 chunks +17 lines, -35 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Nico
4 years ago (2016-11-29 20:45:18 UTC) #4
hans
https://codereview.chromium.org/2536093004/diff/1/docs/clang.md File docs/clang.md (right): https://codereview.chromium.org/2536093004/diff/1/docs/clang.md#newcode115 docs/clang.md:115: * You might have to tweak warning flags.## Using ...
4 years ago (2016-11-29 20:55:57 UTC) #5
Nico
thanks! https://codereview.chromium.org/2536093004/diff/1/docs/clang.md File docs/clang.md (right): https://codereview.chromium.org/2536093004/diff/1/docs/clang.md#newcode115 docs/clang.md:115: * You might have to tweak warning flags.## ...
4 years ago (2016-11-29 20:57:36 UTC) #7
hans
lgtm
4 years ago (2016-11-29 20:58:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536093004/20001
4 years ago (2016-11-29 21:00:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 22:42:23 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-29 22:45:47 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a46c2d1e1e2c7f34ef28c9cdde244e7d267f11f
Cr-Commit-Position: refs/heads/master@{#435098}

Powered by Google App Engine
This is Rietveld 408576698