Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2536073003: Cleanup handoff_manager.h header. (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup handoff_manager.h header. Moves ivars to implementation files and moves the objc_property_releaser include into implementation file, so that code built with ARC can depend on it. BUG=None Committed: https://crrev.com/6e97ef0a6037f946130253f03e722d115e7dbe5d Cr-Commit-Position: refs/heads/master@{#435004}

Patch Set 1 #

Patch Set 2 : git cl w #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M components/handoff/handoff_manager.h View 2 chunks +1 line, -9 lines 0 comments Download
M components/handoff/handoff_manager.mm View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
stkhapugin
PTAL
4 years ago (2016-11-29 15:30:06 UTC) #2
erikchen
lgtm
4 years ago (2016-11-29 15:31:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536073003/20001
4 years ago (2016-11-29 15:41:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 16:14:36 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 16:17:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e97ef0a6037f946130253f03e722d115e7dbe5d
Cr-Commit-Position: refs/heads/master@{#435004}

Powered by Google App Engine
This is Rietveld 408576698