Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2536063003: Clean up WebVR RequestPresent and make callback asynchronous. (Closed)

Created:
4 years ago by bshe
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Clean up WebVR RequestPresent and make callback asynchronous. BUG=665006 Review-Url: https://codereview.chromium.org/2510873003 Cr-Commit-Position: refs/heads/master@{#433063} (cherry picked from commit f97e23678abe358ec7c7241fe5511708be863625) Committed: https://chromium.googlesource.com/chromium/src/+/12d1a2f70164556c8fb55ef1a9bd8604aec15095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -155 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 19 chunks +92 lines, -78 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 1 chunk +22 lines, -10 lines 0 comments Download
M device/vr/android/gvr/gvr_delegate.h View 1 chunk +3 lines, -2 lines 0 comments Download
M device/vr/android/gvr/gvr_device.h View 1 chunk +2 lines, -1 line 0 comments Download
M device/vr/android/gvr/gvr_device.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/android/gvr/gvr_device_provider.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M device/vr/test/fake_vr_device.h View 1 chunk +2 lines, -1 line 0 comments Download
M device/vr/test/fake_vr_device.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M device/vr/vr_device.h View 1 chunk +2 lines, -1 line 0 comments Download
M device/vr/vr_device.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M device/vr/vr_display_impl.h View 3 chunks +8 lines, -2 lines 0 comments Download
M device/vr/vr_display_impl.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 4 chunks +45 lines, -37 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bshe
4 years ago (2016-11-29 20:14:22 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
12d1a2f70164556c8fb55ef1a9bd8604aec15095.

Powered by Google App Engine
This is Rietveld 408576698