Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: net/quic/core/quic_headers_stream_test.cc

Issue 2536033004: Remove uses of gfe2::test::GenerateBody from QUIC code and use the string fill constructor instead. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/core/quic_spdy_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_headers_stream_test.cc
diff --git a/net/quic/core/quic_headers_stream_test.cc b/net/quic/core/quic_headers_stream_test.cc
index 167dfcefe2c2b6e6ccc9606473c4f039f701edd5..d1f728a659077a35d78ba00eeb1184cba90f7974 100644
--- a/net/quic/core/quic_headers_stream_test.cc
+++ b/net/quic/core/quic_headers_stream_test.cc
@@ -949,7 +949,6 @@ TEST_P(QuicHeadersStreamTest, WritevStreamData) {
QuicStreamId id = kClientDataStreamId1;
QuicStreamOffset offset = 0;
struct iovec iov;
- string data;
// This test will issue a write that will require fragmenting into
// multiple HTTP/2 DATA frames.
@@ -958,7 +957,7 @@ TEST_P(QuicHeadersStreamTest, WritevStreamData) {
kSpdyInitialFrameSizeLimit * kMinDataFrames + 1024;
// Set headers stream send window large enough for data written below.
headers_stream_->flow_controller()->UpdateSendWindowOffset(data_len * 2 * 4);
- test::GenerateBody(&data, data_len);
+ string data(data_len, 'a');
for (bool fin : {true, false}) {
for (bool use_ack_listener : {true, false}) {
@@ -1022,7 +1021,6 @@ TEST_P(QuicHeadersStreamTest, WritevStreamDataSendBlocked) {
QuicStreamId id = kClientDataStreamId1;
QuicStreamOffset offset = 0;
struct iovec iov;
- string data;
// This test will issue a write that will require fragmenting into
// multiple HTTP/2 DATA frames. It will ensure that only 1 frame
@@ -1033,7 +1031,7 @@ TEST_P(QuicHeadersStreamTest, WritevStreamDataSendBlocked) {
const size_t data_len = kSpdyInitialFrameSizeLimit * kMinDataFrames + 1024;
// Set headers stream send window large enough for data written below.
headers_stream_->flow_controller()->UpdateSendWindowOffset(data_len * 2 * 4);
- test::GenerateBody(&data, data_len);
+ string data(data_len, 'a');
bool fin = true;
// So force the underlying |WritevData| to consume only 1 byte.
« no previous file with comments | « no previous file | net/quic/core/quic_spdy_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698