Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: third_party/WebKit/public/platform/WebAudioSourceProvider.h

Issue 2536033003: Clarify thread safety of WebAudioSourceProvider interface. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebAudioSourceProvider.h
diff --git a/third_party/WebKit/public/platform/WebAudioSourceProvider.h b/third_party/WebKit/public/platform/WebAudioSourceProvider.h
index 115dd96ef37a64fb9b8d8c2b2914cf36617338b8..a901d8c2ed99f75190692478692fba50a25f0a56 100644
--- a/third_party/WebKit/public/platform/WebAudioSourceProvider.h
+++ b/third_party/WebKit/public/platform/WebAudioSourceProvider.h
@@ -37,11 +37,12 @@ class WebAudioSourceProvider {
virtual ~WebAudioSourceProvider() {}
// provideInput() gets called repeatedly to render time-slices of a continuous
- // audio stream.
+ // audio stream. May be called from any thread.
virtual void provideInput(const WebVector<float*>& audioData,
size_t numberOfFrames) = 0;
// If a client is set, we call it back when the audio format is available.
+ // Must always be called from the same thread.
Raymond Toy 2016/11/29 19:17:12 "same thread" as what?
DaleCurtis 2016/11/29 19:21:40 I.e. if you're on t0 and call setClient(), all fut
Raymond Toy 2016/11/29 19:23:50 I think that's a perfect comment. "All future call
DaleCurtis 2016/11/29 19:30:22 Done.
virtual void setClient(WebAudioSourceProviderClient*) {}
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698