Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253603004: Make it so net/ can be built without file:// support. (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 7 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Make it so net/ can be built without file:// support. This is a step towards making it possible to build net/ without ICU. ICU is used by directory_lister.cc, which is used for creating file directory listings. BUG=362608 R=mef@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268766

Patch Set 1 : Run trybots without file support (Linking should fail at some layer above net) #

Patch Set 2 : Enable file support, add TODO #

Patch Set 3 : Fix BUILD.gn #

Patch Set 4 : Add TODO, minor cleanups #

Total comments: 4

Patch Set 5 : Response to comments #

Patch Set 6 : enable -> disable in GN #

Patch Set 7 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -13 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 3 chunks +7 lines, -0 lines 0 comments Download
M net/BUILD.gn View 1 2 3 4 5 6 3 chunks +21 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 2 chunks +24 lines, -0 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 2 3 4 5 6 6 chunks +10 lines, -2 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 3 4 5 6 4 chunks +16 lines, -3 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 4 5 6 5 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mmenke
This currently adds a variable to common. Per brett's comment on the other CL, perhaps ...
6 years, 7 months ago (2014-05-05 15:08:51 UTC) #1
mef
https://codereview.chromium.org/253603004/diff/60001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/253603004/diff/60001/net/BUILD.gn#newcode40 net/BUILD.gn:40: enable_file_support = 1 is there file support on ios? ...
6 years, 7 months ago (2014-05-06 15:21:29 UTC) #2
mmenke
https://codereview.chromium.org/253603004/diff/60001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/253603004/diff/60001/net/BUILD.gn#newcode40 net/BUILD.gn:40: enable_file_support = 1 On 2014/05/06 15:21:30, mef wrote: > ...
6 years, 7 months ago (2014-05-06 18:13:06 UTC) #3
mef
lgtm
6 years, 7 months ago (2014-05-06 21:51:56 UTC) #4
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 7 months ago (2014-05-06 22:00:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/253603004/150001
6 years, 7 months ago (2014-05-06 22:02:32 UTC) #6
mmenke
On 2014/05/06 22:02:32, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 7 months ago (2014-05-07 00:15:08 UTC) #7
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 7 months ago (2014-05-07 00:15:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/253603004/170001
6 years, 7 months ago (2014-05-07 00:17:45 UTC) #9
mmenke
6 years, 7 months ago (2014-05-07 15:05:31 UTC) #10
Message was sent while issue was closed. 
Committed patchset #7 manually as r268766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698