Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2536003002: Add virtual keyboard item into opt-in IME menu. (Closed)

Created:
4 years ago by tdanderson
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Add virtual keyboard item into opt-in IME menu. The 'Smart deploy toggle' is always hidden in opt-in IME menu. We should show/hide it based on the vr and devices state. Make ImeMenuTray listens on the virtual keyboard state to show the toggle. Currently the ImeMenuBubble doesn't support update UI. So if there's state change (which leads to UI change) of the VK, just hide the bubble. BUG=668013 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2474843002 Cr-Commit-Position: refs/heads/master@{#434127} (cherry picked from commit 1fb9e7720d5a4ddaef6ce257f4d252a831bea688) Committed: https://chromium.googlesource.com/chromium/src/+/1511d6037dd138d551a42c36e21264cd4428aa9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_menu_tray.h View 5 chunks +11 lines, -1 line 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 5 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tdanderson
4 years ago (2016-11-28 22:15:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1511d6037dd138d551a42c36e21264cd4428aa9d.

Powered by Google App Engine
This is Rietveld 408576698