Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2535983004: Makes sure bounds and visibilty are updated correctly for new displays (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes sure bounds and visibilty are updated correctly for new displays When WindowTreeClient is told about a new display it was not fully configuring the WindowTreeHost. This patch makes the bounds and visibility match. BUG=664625 TEST=none R=ben@chromium.org Committed: https://crrev.com/189712a4cd41d68fc08c4b054d3ed2d6a6b1e3a1 Cr-Commit-Position: refs/heads/master@{#435384}

Patch Set 1 #

Total comments: 2

Patch Set 2 : always #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -20 lines) Patch
M services/ui/test_wm/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/test_wm/test_wm.cc View 1 2 4 chunks +11 lines, -6 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 2 3 chunks +8 lines, -2 lines 0 comments Download
M ui/aura/mus/window_tree_client_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 2 2 chunks +11 lines, -3 lines 0 comments Download
M ui/aura/test/mus/window_tree_client_private.h View 3 chunks +6 lines, -2 lines 0 comments Download
M ui/aura/test/mus/window_tree_client_private.cc View 2 chunks +8 lines, -1 line 0 comments Download
M ui/aura/test/test_screen.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
sky
4 years ago (2016-11-29 23:15:41 UTC) #1
sadrul
lgtm https://codereview.chromium.org/2535983004/diff/1/ui/aura/mus/window_tree_client.cc File ui/aura/mus/window_tree_client.cc (right): https://codereview.chromium.org/2535983004/diff/1/ui/aura/mus/window_tree_client.cc#newcode382 ui/aura/mus/window_tree_client.cc:382: window_data->bounds); Should this set bounds regardless of visibility?
4 years ago (2016-11-29 23:29:28 UTC) #5
sky
https://codereview.chromium.org/2535983004/diff/1/ui/aura/mus/window_tree_client.cc File ui/aura/mus/window_tree_client.cc (right): https://codereview.chromium.org/2535983004/diff/1/ui/aura/mus/window_tree_client.cc#newcode382 ui/aura/mus/window_tree_client.cc:382: window_data->bounds); On 2016/11/29 23:29:28, sadrul wrote: > Should this ...
4 years ago (2016-11-29 23:35:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535983004/20001
4 years ago (2016-11-29 23:35:56 UTC) #9
Ben Goodger (Google)
lgtm
4 years ago (2016-11-30 00:24:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on ...
4 years ago (2016-11-30 01:38:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535983004/20001
4 years ago (2016-11-30 03:01:40 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-30 05:03:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535983004/20001
4 years ago (2016-11-30 16:11:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535983004/40001
4 years ago (2016-11-30 18:53:01 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-30 19:49:45 UTC) #23
commit-bot: I haz the power
4 years ago (2016-11-30 19:54:01 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/189712a4cd41d68fc08c4b054d3ed2d6a6b1e3a1
Cr-Commit-Position: refs/heads/master@{#435384}

Powered by Google App Engine
This is Rietveld 408576698