common/eslint/eslint/smoke_test.py - Issue 2535983002: [eslint] Don't treat eslint warnings as PRESUBMIT errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/eslint/eslint/smoke_test.py

Issue 2535983002: [eslint] Don't treat eslint warnings as PRESUBMIT errors (Closed)

Patch Set: fix smoke test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: common/eslint/eslint/smoke_test.py

diff --git a/common/eslint/eslint/smoke_test.py b/common/eslint/eslint/smoke_test.py

index 396131dc031f6d2473f331b4420aec6232e1cef0..9a0f442488dcff106e1827580b4d4747792d9d64 100644

--- a/common/eslint/eslint/smoke_test.py

+++ b/common/eslint/eslint/smoke_test.py

@@ -29,7 +29,8 @@ class SmokeTest(unittest.TestCase):

tmp_file.write(_TEMP_FILE_CONTENTS)

tmp_file.close()

- output = eslint.RunEslintOnFiles([tmp_file.name])

+ success, output = eslint.RunEslint([tmp_file.name])

+ self.assertFalse(success)

self.assertTrue('is not in camel case' in output)

finally:

os.remove(tmp_file.name)

« no previous file with comments | « common/eslint/eslint/__init__.py ('k') | no next file » | no next file with comments »