Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4091)

Unified Diff: catapult_build/js_checks.py

Issue 2535983002: [eslint] Don't treat eslint warnings as PRESUBMIT errors (Closed)
Patch Set: fix smoke test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .eslintignore ('k') | common/eslint/bin/run_eslint » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: catapult_build/js_checks.py
diff --git a/catapult_build/js_checks.py b/catapult_build/js_checks.py
index 5c6b68716070e81ad1ba0ba3f7385cc76b1b559d..2af873dbf75a26c1909e5a79dbed1c74ee9cb11a 100644
--- a/catapult_build/js_checks.py
+++ b/catapult_build/js_checks.py
@@ -84,10 +84,10 @@ class JSChecker(object):
error_lines += filter(None, [self.ConstCheck(i, line)])
if affected_js_files:
- eslint_output = eslint.RunEslintOnFiles(
- [f.AbsoluteLocalPath() for f in affected_js_files]).rstrip()
+ success, eslint_output = eslint.RunEslint(
+ [f.AbsoluteLocalPath() for f in affected_js_files])
- if eslint_output:
+ if not success:
error_lines.append('\neslint found lint errors:')
error_lines.append(eslint_output)
« no previous file with comments | « .eslintignore ('k') | common/eslint/bin/run_eslint » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698