Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: common/eslint/bin/run_eslint

Issue 2535983002: [eslint] Don't treat eslint warnings as PRESUBMIT errors (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: common/eslint/bin/run_eslint
diff --git a/common/eslint/bin/run_eslint b/common/eslint/bin/run_eslint
index 0e199908252b2fc5fba6da98b64a1a372adeb013..220f74be34ceb99d8815b0b04ef658b203a6d34f 100755
--- a/common/eslint/bin/run_eslint
+++ b/common/eslint/bin/run_eslint
@@ -35,7 +35,7 @@ if __name__ == '__main__':
parser = argparse.ArgumentParser(
description='Wrapper script to run eslint on Catapult code')
parser.add_argument('--files', '-f', default=None, nargs='+', metavar='FILE',
charliea (OOO until 10-5) 2016/11/28 21:54:21 (Here and wherever makes sense) can you change "fi
eakuefner 2016/11/28 22:27:50 Done.
- help='List of files to lint')
+ help='List of files/dirs to lint')
parser.add_argument('--all', default=None, action='store_true',
help='Runs eslint on all applicable Catapult code')
parser.add_argument('--extra-args', default=None, type=str,
@@ -49,7 +49,7 @@ if __name__ == '__main__':
sys.exit(1)
if args.all:
- print eslint.RunEslintOnDirs(
- DIRECTORIES_TO_LINT, extra_args=args.extra_args)
+ print eslint.RunEslint(
+ DIRECTORIES_TO_LINT, extra_args=args.extra_args)[0]
else:
- print eslint.RunEslintOnFiles(args.files, extra_args=args.extra_args)
+ print eslint.RunEslint(args.files, extra_args=args.extra_args)[0]

Powered by Google App Engine
This is Rietveld 408576698