Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: ui/views/controls/scrollbar/cocoa_scroll_bar.mm

Issue 2535943002: Fix event targeting for overlay scrollbar thumbs (in native UI). (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/scrollbar/base_scroll_bar.cc ('k') | ui/views/controls/scrollbar/overlay_scroll_bar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/scrollbar/cocoa_scroll_bar.mm
diff --git a/ui/views/controls/scrollbar/cocoa_scroll_bar.mm b/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
index 432c43aba43d7ab14ae05aae33629532df44a144..40390cd1b95227b67b4369d2cb1166805f861ab6 100644
--- a/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
+++ b/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
@@ -161,7 +161,7 @@ void CocoaScrollBarThumb::OnMouseExited(const ui::MouseEvent& event) {
// CocoaScrollBar class
CocoaScrollBar::CocoaScrollBar(bool horizontal)
- : BaseScrollBar(horizontal, new CocoaScrollBarThumb(this)),
+ : BaseScrollBar(horizontal),
hide_scrollbar_timer_(
FROM_HERE,
base::TimeDelta::FromMilliseconds(kScrollbarHideTimeoutMs),
@@ -171,6 +171,7 @@ CocoaScrollBar::CocoaScrollBar(bool horizontal)
last_contents_scroll_offset_(0),
is_expanded_(false),
did_start_dragging_(false) {
+ SetThumb(new CocoaScrollBarThumb(this));
bridge_.reset([[ViewsScrollbarBridge alloc] initWithDelegate:this]);
scroller_style_ = [ViewsScrollbarBridge getPreferredScrollerStyle];
« no previous file with comments | « ui/views/controls/scrollbar/base_scroll_bar.cc ('k') | ui/views/controls/scrollbar/overlay_scroll_bar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698