Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 253593003: Release the Commands API and add docs for Apps. (Closed)

Created:
6 years, 8 months ago by Finnur
Modified:
6 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Release the Commands Extension API and add docs for Apps. BUG=302437, 364904, 329878 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266379

Patch Set 1 #

Patch Set 2 : Docs too #

Patch Set 3 : Fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -53 lines) Patch
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +5 lines, -18 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_manifest_unittest.cc View 1 2 1 chunk +10 lines, -35 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/commands.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Finnur
6 years, 8 months ago (2014-04-25 16:01:05 UTC) #1
Yoyo Zhou
LGTM
6 years, 8 months ago (2014-04-25 19:08:35 UTC) #2
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 8 months ago (2014-04-25 20:28:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/253593003/40001
6 years, 8 months ago (2014-04-25 22:06:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 00:11:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-26 00:11:25 UTC) #6
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 8 months ago (2014-04-26 09:34:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/253593003/40001
6 years, 8 months ago (2014-04-26 09:35:16 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 22:08:45 UTC) #9
Message was sent while issue was closed.
Change committed as 266379

Powered by Google App Engine
This is Rietveld 408576698