Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2535923003: Use JNI UnguessableToken in ScopedSurfaceRequest (Closed)

Created:
4 years ago by tguilbert
Modified:
4 years ago
Reviewers:
palmer, michaelbai, Ted C
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use JNI UnguessableToken in ScopedSurfaceRequest d8b550c725757a369fd04dee74f5309ab5637569 introduced a JNI wrapper for base::UnguessableToken. This change uses the wrapper to send parcelled tokens when fulfilling a ScopedSurfaceRequest, instead of two jlongs. BUG= TEST= verified we could still play HLS. Committed: https://crrev.com/009759543eb475e7ccb5c61f741c18a780c48902 Cr-Commit-Position: refs/heads/master@{#434815}

Patch Set 1 #

Messages

Total messages: 21 (13 generated)
tguilbert
Hello! Please OWNERS review the following files: michaelbai@: content/app/android/* palmer@: *.aidl tedchoc@: content/public/android/*, content/browser/android/* Thank ...
4 years ago (2016-11-28 23:04:24 UTC) #4
tguilbert
Forgot to add palmer@ Please review the *.aidl changes. TY!
4 years ago (2016-11-28 23:06:48 UTC) #6
Ted C
On 2016/11/28 23:04:24, tguilbert wrote: > Hello! > > Please OWNERS review the following files: ...
4 years ago (2016-11-28 23:54:57 UTC) #7
palmer
lgtm
4 years ago (2016-11-29 00:43:24 UTC) #8
michaelbai
content/app/android/ LGTM
4 years ago (2016-11-29 00:59:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535923003/1
4 years ago (2016-11-29 01:10:01 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 01:40:49 UTC) #19
commit-bot: I haz the power
4 years ago (2016-11-29 01:44:18 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/009759543eb475e7ccb5c61f741c18a780c48902
Cr-Commit-Position: refs/heads/master@{#434815}

Powered by Google App Engine
This is Rietveld 408576698