Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: client/isolate/isolate.go

Issue 2535803004: isolate: give up and die on file unavailability (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« client/archiver/directory.go ('K') | « client/archiver/directory_test.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/isolate/isolate.go
diff --git a/client/isolate/isolate.go b/client/isolate/isolate.go
index a0ddfed085defa634cc2067e612f0f6e7c377f98..bfb9f628f26a05cde7881fc2ca02c85891e09ad1 100644
--- a/client/isolate/isolate.go
+++ b/client/isolate/isolate.go
@@ -279,7 +279,9 @@ func archive(arch *archiver.Archiver, opts *ArchiveOptions, displayName string)
if mode&os.ModeSymlink == os.ModeSymlink {
l, err := os.Readlink(dep)
if err != nil {
- return nil, err
+ // Kill the process: there's no reason to continue if a file is
+ // unavailable.
+ log.Fatalf("Unable to stat %q: %v", dep, err)
}
i.Files[relPath] = isolated.SymLink(l)
} else {
« client/archiver/directory.go ('K') | « client/archiver/directory_test.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698