isolate: give up and die on file unavailability

client/archiver/directory_test.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package archiver
 
 import (
         "encoding/json"
         "errors"
-        "fmt"
         "io/ioutil"
         "net/http/httptest"
         "os"
         "path/filepath"
         "sync"
         "testing"
 
         "github.com/luci/luci-go/client/internal/common"
         "github.com/luci/luci-go/common/data/text/units"
         "github.com/luci/luci-go/common/isolated"
         "github.com/luci/luci-go/common/isolatedclient"
         "github.com/luci/luci-go/common/isolatedclient/isolatedfake"
         "github.com/maruel/ut"
 )
 
-func TestWalkInexistent(t *testing.T) {
-        ch := make(chan *walkItem)
-        var wg sync.WaitGroup
-        wg.Add(1)
-        go func() {
-                defer wg.Done()
-                defer close(ch)
-                walk("inexistent_directory", nil, ch)
-        }()
-        item := <-ch
-        osErr := "lstat inexistent_directory: no such file or directory"
-        if common.IsWindows() {
-                osErr = "GetFileAttributesEx inexistent_directory: The system cannot find the file specified."
-        }
-        err := fmt.Errorf("walk(inexistent_directory): %s", osErr)
-        ut.AssertEqual(t, &walkItem{err: err}, item)
-        item, ok := <-ch
-        ut.AssertEqual(t, (*walkItem)(nil), item)
-        ut.AssertEqual(t, false, ok)
-        wg.Wait()
-}
-
 func TestWalkBadRegexp(t *testing.T) {
         ch := make(chan *walkItem)
         var wg sync.WaitGroup
         wg.Add(1)
         go func() {
                 defer wg.Done()
                 defer close(ch)
                 walk("inexistent", []string{"a["}, ch)
         }()
         item := <-ch
@@ skipping 70 matching lines @@
 
         stats := a.Stats()
         ut.AssertEqual(t, 0, stats.TotalHits())
         // There're 3 cache misses even if the same content is looked up twice.
         ut.AssertEqual(t, 3, stats.TotalMisses())
         ut.AssertEqual(t, units.Size(0), stats.TotalBytesHits())
         ut.AssertEqual(t, units.Size(3+3+len(isolatedEncoded)), stats.TotalBytesPushed())
 
         ut.AssertEqual(t, nil, server.Error())
 }