Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5660)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm

Issue 25358002: [rAC, OSX] Stop suggestions/inputs from flickering (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove bad DCHECK. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/autofill/autofill_section_container.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm
index e4b4694031160e469665c0f469d9c253217dd9ca..d2d2b5f557a35ee878327acaa2c2a21c6ee23b15 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm
@@ -80,11 +80,9 @@ void AutofillDialogCocoa::CloseNow() {
}
void AutofillDialogCocoa::UpdatesStarted() {
- // TODO(estade): implement if it makes sense to.
}
void AutofillDialogCocoa::UpdatesFinished() {
- // TODO(estade): implement if it makes sense to.
}
void AutofillDialogCocoa::UpdateAccountChooser() {
@@ -335,11 +333,15 @@ void AutofillDialogCocoa::OnConstrainedWindowClosed(
}
- (void)onContentViewFrameDidChange:(NSNotification*)notification {
- [self performLayout];
+ [self requestRelayout];
}
- (void)requestRelayout {
- [self performLayout];
+ SEL sel = @selector(performLayout);
+ [NSObject cancelPreviousPerformRequestsWithTarget:self
+ selector:sel
+ object:nil];
+ [self performSelector:sel withObject:nil afterDelay:0.0];
}
- (NSSize)preferredSize {
@@ -450,6 +452,8 @@ void AutofillDialogCocoa::OnConstrainedWindowClosed(
name:NSWindowDidMoveNotification
object:[self window]];
+ [self updateAccountChooser];
+ [self updateNotificationArea];
[self requestRelayout];
}
@@ -507,7 +511,7 @@ void AutofillDialogCocoa::OnConstrainedWindowClosed(
[signInContainer_ loadSignInPage];
[[mainContainer_ view] setHidden:YES];
[[signInContainer_ view] setHidden:NO];
- [self performLayout];
+ [self requestRelayout];
return [signInContainer_ navigationController];
}
@@ -524,7 +528,7 @@ void AutofillDialogCocoa::OnConstrainedWindowClosed(
- (void)hideSignIn {
[[signInContainer_ view] setHidden:YES];
[[mainContainer_ view] setHidden:NO];
- [self performLayout];
+ [self requestRelayout];
}
- (void)modelChanged {
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/autofill/autofill_section_container.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698