[rAC, OSX] Stop suggestions/inputs from flickering

[rAC, OSX] Stop suggestions/inputs from flickering

Stop visual dialog flicker when switching a section's input source from
manual to suggestions or vice versa.

1) Coalesce "requestRelayout" messages, so they are only called once
   the current RunLoop iteration is done. Previously, they were
   executed immediately on each individual data change - multiple times
   while the controller was updating.

2) Change visibility of suggestions/inputs _after_ the views have been
   laid out. Prevents briefly observable layout flow.

NOTRY=true
BUG=286530
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226375

[groby-ooo-7-16, 2013-09-30 21:59:56]

rsesek: PTAL

[Robert Sesek, 2013-09-30 22:06:08]

Do the tests pass with this? You may need NSRunLoopRunAllPending(). If so, LGTM.

[groby-ooo-7-16, 2013-09-30 22:22:36]

AFAICT, all tests pass - presumably due to the fact that they're all browser
tests and already do a boatload of things waiting for various tasks to complete.

[commit-bot: I haz the power, 2013-09-30 22:23:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/25358002/1

[commit-bot: I haz the power, 2013-10-01 03:35:47]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[groby-ooo-7-16, 2013-10-01 17:56:29]

Odd. Passing locally. Investigating further...

[groby-ooo-7-16, 2013-10-01 21:18:32]

That was fun. 

Turns out that I have "Full Keyboard Access: All Controls", trybots have ":Text
boxes and lists only".

That means during the test flow, on the local machine a combobox is first
responder and all is fine. On the try bots, a text field is first responder. The
test controller then hides the dialog section in question, causing the
controlTextDidEndEditing to fire - which triggers a validation of the section.

Could probably restructure the code to not fire this message if the section is
hidden, but there's no harm in validating the section even if it is hidden.

[groby-ooo-7-16, 2013-10-01 21:19:45]

(Sorry - also merged to HEAD, that caused all the non-DCHECK changes)

[Robert Sesek, 2013-10-01 21:40:33]

Still LGTM

[commit-bot: I haz the power, 2013-10-01 21:47:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/25358002/30001

[commit-bot: I haz the power, 2013-10-01 22:54:31]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[groby-ooo-7-16, 2013-10-02 01:09:48]

NOTRY=true because the CQ hates me

[commit-bot: I haz the power, 2013-10-02 01:10:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/25358002/30001

[commit-bot: I haz the power, 2013-10-02 01:11:53]

Change committed as 226375