Chromium Code Reviews
DescriptionRevert of Blink Animation: Extend Animation's GC lifetime if it has a finish promise. (patchset #2 id:20001 of https://codereview.chromium.org/2536523002/ )
Reason for revert:
Causes unexpected leaks in webkit_tests:
web-animations-api/animation-finish-event-cancelled.html
web-animations-api/animation-cancel-ready-finished-ordering.html
imported/wpt/web-animations/interfaces/Animation/finished.html
web-animations-api/animation-onfinish.html
imported/wpt/web-animations/interfaces/Animation/oncancel.html
http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker.html
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/342
Original issue's description:
> Blink Animation: Extend Animation's GC lifetime if it has a finish promise.
>
> BUG=617539
>
> Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873
> Cr-Commit-Position: refs/heads/master@{#434612}
TBR=alancutter@chromium.org,loyso@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617539
Committed: https://crrev.com/ed16c60bdef2a6fca694e312d5a77e5b93d538d2
Cr-Commit-Position: refs/heads/master@{#434646}
Patch Set 1 #
Messages
Total messages: 9 (4 generated)
|
||||||||||||||||||||||||||||