Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2535793002: Revert of Blink Animation: Extend Animation's GC lifetime if it has a finish promise. (Closed)

Created:
4 years ago by magjed_chromium
Modified:
4 years ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Blink Animation: Extend Animation's GC lifetime if it has a finish promise. (patchset #2 id:20001 of https://codereview.chromium.org/2536523002/ ) Reason for revert: Causes unexpected leaks in webkit_tests: web-animations-api/animation-finish-event-cancelled.html web-animations-api/animation-cancel-ready-finished-ordering.html imported/wpt/web-animations/interfaces/Animation/finished.html web-animations-api/animation-onfinish.html imported/wpt/web-animations/interfaces/Animation/oncancel.html http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker.html https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/342 Original issue's description: > Blink Animation: Extend Animation's GC lifetime if it has a finish promise. > > BUG=617539 > > Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873 > Cr-Commit-Position: refs/heads/master@{#434612} TBR=alancutter@chromium.org,loyso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617539 Committed: https://crrev.com/ed16c60bdef2a6fca694e312d5a77e5b93d538d2 Cr-Commit-Position: refs/heads/master@{#434646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
D third_party/WebKit/LayoutTests/web-animations-api/animation-finish-promise-gc.html View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
magjed_chromium
Created Revert of Blink Animation: Extend Animation's GC lifetime if it has a finish promise.
4 years ago (2016-11-28 13:34:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535793002/1
4 years ago (2016-11-28 13:35:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 13:35:59 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ed16c60bdef2a6fca694e312d5a77e5b93d538d2 Cr-Commit-Position: refs/heads/master@{#434646}
4 years ago (2016-11-28 13:37:26 UTC) #8
loyso (OOO)
4 years ago (2016-11-29 00:01:12 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698