Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 2535773004: Make sure stylus tools are always hidden if disabled by the user. (Closed)

Created:
4 years ago by jdufault
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure stylus tools are always hidden if disabled by the user. BUG=666450 Committed: https://crrev.com/04d83e71145866d8d7cea925f4ff2c57c0c9bd03 Cr-Commit-Position: refs/heads/master@{#434717}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ash/common/system/chromeos/palette/palette_tray.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
jdufault
stevenjb@ PTAL. Thanks!
4 years ago (2016-11-28 18:26:07 UTC) #7
stevenjb
https://codereview.chromium.org/2535773004/diff/1/ash/common/system/chromeos/palette/palette_tray.h File ash/common/system/chromeos/palette/palette_tray.h (right): https://codereview.chromium.org/2535773004/diff/1/ash/common/system/chromeos/palette/palette_tray.h#newcode127 ash/common/system/chromeos/palette/palette_tray.h:127: // True if the user has disabled the palette. ...
4 years ago (2016-11-28 18:47:26 UTC) #8
jdufault
https://codereview.chromium.org/2535773004/diff/1/ash/common/system/chromeos/palette/palette_tray.h File ash/common/system/chromeos/palette/palette_tray.h (right): https://codereview.chromium.org/2535773004/diff/1/ash/common/system/chromeos/palette/palette_tray.h#newcode127 ash/common/system/chromeos/palette/palette_tray.h:127: // True if the user has disabled the palette. ...
4 years ago (2016-11-28 19:07:48 UTC) #10
stevenjb
lgtm
4 years ago (2016-11-28 19:08:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535773004/20001
4 years ago (2016-11-28 19:12:08 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 21:05:32 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-28 21:07:34 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04d83e71145866d8d7cea925f4ff2c57c0c9bd03
Cr-Commit-Position: refs/heads/master@{#434717}

Powered by Google App Engine
This is Rietveld 408576698