Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2535773003: Increase subprocess timeout in standalone/io/test_runner_test. (Closed)

Created:
4 years ago by Bill Hesse
Modified:
4 years ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Increase subprocess timeout in standalone/io/test_runner_test. A passing subtest was sometimes taking more than 10 seconds, and timing out. BUG=https://github.com/dart-lang/sdk/issues/20351 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/0bb0386634c3d7a8be64e9c3359b6c034115f178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/standalone/io/test_runner_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
The linux vm debug x64 bot is failing flakily on this test.
4 years ago (2016-11-28 16:38:21 UTC) #2
kustermann
lgtm
4 years ago (2016-11-28 16:42:15 UTC) #3
Bill Hesse
4 years ago (2016-11-28 16:42:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0bb0386634c3d7a8be64e9c3359b6c034115f178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698