Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2535753009: Couple of changes for client area (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, rjkroege, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Couple of changes for client area Makes DesktopWindowTreeHostMus update the client area on the server any time the bounds change. Makes DesktopNativeWidgetAura not update the transparency and fills-bounds-completely of the content_window_. This way DesktopNativeWidgetAura won't fill the client area and you can see the client decorations from the window manager. Also DesktopWindowTreeHostMus makes sure to mark the content_window_ layer as not fills bounds opaquely for same reason. Lastly makes it so the client that changes the client area isn't told about the change, and a bit of logging that fits in with other logging in the file. BUG=664625 663525 TEST=none R=erg@chromium.org Committed: https://crrev.com/2e855ae5b7a081bc374880e100fe4b00887c0f48 Cr-Commit-Position: refs/heads/master@{#435696}

Patch Set 1 #

Patch Set 2 : order #

Total comments: 2

Patch Set 3 : nuke todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M services/ui/ws/operation.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/window_tree.cc View 1 chunk +13 lines, -1 line 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 1 2 4 chunks +13 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sky
4 years ago (2016-12-01 19:18:10 UTC) #1
Elliot Glaysher
lgtm https://codereview.chromium.org/2535753009/diff/20001/ui/views/mus/desktop_window_tree_host_mus.cc File ui/views/mus/desktop_window_tree_host_mus.cc (right): https://codereview.chromium.org/2535753009/diff/20001/ui/views/mus/desktop_window_tree_host_mus.cc#newcode139 ui/views/mus/desktop_window_tree_host_mus.cc:139: // be called after window size changed. I ...
4 years ago (2016-12-01 19:21:24 UTC) #4
sky
https://codereview.chromium.org/2535753009/diff/20001/ui/views/mus/desktop_window_tree_host_mus.cc File ui/views/mus/desktop_window_tree_host_mus.cc (right): https://codereview.chromium.org/2535753009/diff/20001/ui/views/mus/desktop_window_tree_host_mus.cc#newcode139 ui/views/mus/desktop_window_tree_host_mus.cc:139: // be called after window size changed. On 2016/12/01 ...
4 years ago (2016-12-01 19:23:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535753009/40001
4 years ago (2016-12-01 19:24:49 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-01 20:20:02 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 20:22:27 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2e855ae5b7a081bc374880e100fe4b00887c0f48
Cr-Commit-Position: refs/heads/master@{#435696}

Powered by Google App Engine
This is Rietveld 408576698