Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: tools/grit/grit_rule.gni

Issue 2535753007: Move mac_views_browser grit define out of tools/grit. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/features.gni ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Instantiate grit. This will produce a script target to run grit, and a 5 # Instantiate grit. This will produce a script target to run grit, and a
6 # static library that compiles the .cc files. 6 # static library that compiles the .cc files.
7 # 7 #
8 # Parameters 8 # Parameters
9 # 9 #
10 # source (required) 10 # source (required)
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 # grit_flags = [ "-E", "foo=bar" ] # Optional extra flags. 85 # grit_flags = [ "-E", "foo=bar" ] # Optional extra flags.
86 # # You can also put deps here if the grit source depends on generated 86 # # You can also put deps here if the grit source depends on generated
87 # # files. 87 # # files.
88 # } 88 # }
89 import("//build/config/android/config.gni") 89 import("//build/config/android/config.gni")
90 import("//build/config/chrome_build.gni") 90 import("//build/config/chrome_build.gni")
91 import("//build/config/crypto.gni") 91 import("//build/config/crypto.gni")
92 import("//build/config/features.gni") 92 import("//build/config/features.gni")
93 import("//build/config/ui.gni") 93 import("//build/config/ui.gni")
94 import("//third_party/closure_compiler/closure_args.gni") 94 import("//third_party/closure_compiler/closure_args.gni")
95 import("//ui/base/ui_features.gni")
96 95
97 assert(!enable_resource_whitelist_generation || is_android, 96 assert(!enable_resource_whitelist_generation || is_android,
98 "resource whitelist generation only works on android") 97 "resource whitelist generation only works on android")
99 98
100 declare_args() { 99 declare_args() {
101 # When set, this will fork out to grit at GN-time to get all inputs 100 # When set, this will fork out to grit at GN-time to get all inputs
102 # referenced by the .grd file. 101 # referenced by the .grd file.
103 # 102 #
104 # Normal builds don't need this since proper incremental builds are handled 103 # Normal builds don't need this since proper incremental builds are handled
105 # by grit writing out the inputs in .d files at build-time. But for analyze 104 # by grit writing out the inputs in .d files at build-time. But for analyze
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 "-D", 251 "-D",
253 "enable_task_manager", 252 "enable_task_manager",
254 ] 253 ]
255 } 254 }
256 if (enable_notifications) { 255 if (enable_notifications) {
257 grit_defines += [ 256 grit_defines += [
258 "-D", 257 "-D",
259 "enable_notifications", 258 "enable_notifications",
260 ] 259 ]
261 } 260 }
262 if (mac_views_browser) {
263 grit_defines += [
264 "-D",
265 "mac_views_browser",
266 ]
267 }
268 261
269 # TODO(aberent): Enable for other platforms once the build machines have 262 # TODO(aberent): Enable for other platforms once the build machines have
270 # Java on them (and hence can run the closure compiler). 263 # Java on them (and hence can run the closure compiler).
271 _strip_resource_files = is_android 264 _strip_resource_files = is_android
272 _js_minifier = "//third_party/closure_compiler/js_minify.py" 265 _js_minifier = "//third_party/closure_compiler/js_minify.py"
273 266
274 grit_resource_id_file = "//tools/gritsettings/resource_ids" 267 grit_resource_id_file = "//tools/gritsettings/resource_ids"
275 grit_info_script = "//tools/grit/grit_info.py" 268 grit_info_script = "//tools/grit/grit_info.py"
276 269
277 template("grit") { 270 template("grit") {
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 if (defined(invoker.configs)) { 490 if (defined(invoker.configs)) {
498 configs += invoker.configs 491 configs += invoker.configs
499 } 492 }
500 493
501 if (defined(invoker.visibility)) { 494 if (defined(invoker.visibility)) {
502 visibility = invoker.visibility 495 visibility = invoker.visibility
503 } 496 }
504 output_name = grit_output_name 497 output_name = grit_output_name
505 } 498 }
506 } 499 }
OLDNEW
« no previous file with comments | « chrome/common/features.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698