Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2535753007: Move mac_views_browser grit define out of tools/grit. (Closed)

Created:
4 years ago by tapted
Modified:
4 years ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move mac_views_browser grit define out of tools/grit. tools/grit used to add it, but it should move to chrome_grit_defines instead to avoid a ui dependency there. It's currently breaking WebRTC. It's currently used by chrome/app/theme/theme_resources.grd. (ui_resources.grd might need it later, but it doesn't right now). BUG=657244 TBR=scottmg@chromium.org, sky@chromium.org Committed: https://crrev.com/6992f1f07971bf7f2100b6538cf302d8556124ec Cr-Commit-Position: refs/heads/master@{#435582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/common/features.gni View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/grit/grit_rule.gni View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
tapted
4 years ago (2016-12-01 07:51:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535753007/1
4 years ago (2016-12-01 08:07:43 UTC) #12
kjellander_chromium
lgtm thanks! I verified that this solves our problem.
4 years ago (2016-12-01 08:16:15 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 08:38:54 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-01 08:40:50 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6992f1f07971bf7f2100b6538cf302d8556124ec
Cr-Commit-Position: refs/heads/master@{#435582}

Powered by Google App Engine
This is Rietveld 408576698