Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Side by Side Diff: src/compiler/types.cc

Issue 2535753004: [turbofan] Add appropriate types to express Callable. (Closed)
Patch Set: Add spec comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/types.h ('k') | src/runtime/runtime-test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <iomanip> 5 #include <iomanip>
6 6
7 #include "src/compiler/types.h" 7 #include "src/compiler/types.h"
8 8
9 #include "src/handles-inl.h" 9 #include "src/handles-inl.h"
10 #include "src/ostreams.h" 10 #include "src/ostreams.h"
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 return kNumber; 189 return kNumber;
190 case SIMD128_VALUE_TYPE: 190 case SIMD128_VALUE_TYPE:
191 return kSimd; 191 return kSimd;
192 case JS_OBJECT_TYPE: 192 case JS_OBJECT_TYPE:
193 case JS_ARGUMENTS_TYPE: 193 case JS_ARGUMENTS_TYPE:
194 case JS_ERROR_TYPE: 194 case JS_ERROR_TYPE:
195 case JS_GLOBAL_OBJECT_TYPE: 195 case JS_GLOBAL_OBJECT_TYPE:
196 case JS_GLOBAL_PROXY_TYPE: 196 case JS_GLOBAL_PROXY_TYPE:
197 case JS_API_OBJECT_TYPE: 197 case JS_API_OBJECT_TYPE:
198 case JS_SPECIAL_API_OBJECT_TYPE: 198 case JS_SPECIAL_API_OBJECT_TYPE:
199 if (map->is_undetectable()) return kOtherUndetectable; 199 if (map->is_undetectable()) {
200 // Currently we assume that every undetectable receiver is also
201 // callable, which is what we need to support document.all. We
202 // could add another Type bit to support other use cases in the
203 // future if necessary.
204 DCHECK(map->is_callable());
205 return kOtherUndetectable;
206 }
207 if (map->is_callable()) {
208 return kOtherCallable;
209 }
200 return kOtherObject; 210 return kOtherObject;
201 case JS_VALUE_TYPE: 211 case JS_VALUE_TYPE:
202 case JS_MESSAGE_OBJECT_TYPE: 212 case JS_MESSAGE_OBJECT_TYPE:
203 case JS_DATE_TYPE: 213 case JS_DATE_TYPE:
204 case JS_CONTEXT_EXTENSION_OBJECT_TYPE: 214 case JS_CONTEXT_EXTENSION_OBJECT_TYPE:
205 case JS_GENERATOR_OBJECT_TYPE: 215 case JS_GENERATOR_OBJECT_TYPE:
206 case JS_MODULE_NAMESPACE_TYPE: 216 case JS_MODULE_NAMESPACE_TYPE:
207 case JS_FIXED_ARRAY_ITERATOR_TYPE: 217 case JS_FIXED_ARRAY_ITERATOR_TYPE:
208 case JS_ARRAY_BUFFER_TYPE: 218 case JS_ARRAY_BUFFER_TYPE:
209 case JS_ARRAY_TYPE: 219 case JS_ARRAY_TYPE:
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 case JS_FAST_HOLEY_SMI_ARRAY_VALUE_ITERATOR_TYPE: 258 case JS_FAST_HOLEY_SMI_ARRAY_VALUE_ITERATOR_TYPE:
249 case JS_FAST_ARRAY_VALUE_ITERATOR_TYPE: 259 case JS_FAST_ARRAY_VALUE_ITERATOR_TYPE:
250 case JS_FAST_HOLEY_ARRAY_VALUE_ITERATOR_TYPE: 260 case JS_FAST_HOLEY_ARRAY_VALUE_ITERATOR_TYPE:
251 case JS_FAST_DOUBLE_ARRAY_VALUE_ITERATOR_TYPE: 261 case JS_FAST_DOUBLE_ARRAY_VALUE_ITERATOR_TYPE:
252 case JS_FAST_HOLEY_DOUBLE_ARRAY_VALUE_ITERATOR_TYPE: 262 case JS_FAST_HOLEY_DOUBLE_ARRAY_VALUE_ITERATOR_TYPE:
253 case JS_GENERIC_ARRAY_VALUE_ITERATOR_TYPE: 263 case JS_GENERIC_ARRAY_VALUE_ITERATOR_TYPE:
254 264
255 case JS_WEAK_MAP_TYPE: 265 case JS_WEAK_MAP_TYPE:
256 case JS_WEAK_SET_TYPE: 266 case JS_WEAK_SET_TYPE:
257 case JS_PROMISE_TYPE: 267 case JS_PROMISE_TYPE:
268 DCHECK(!map->is_callable());
269 DCHECK(!map->is_undetectable());
270 return kOtherObject;
258 case JS_BOUND_FUNCTION_TYPE: 271 case JS_BOUND_FUNCTION_TYPE:
259 DCHECK(!map->is_undetectable()); 272 DCHECK(!map->is_undetectable());
260 return kOtherObject; 273 return kBoundFunction;
261 case JS_FUNCTION_TYPE: 274 case JS_FUNCTION_TYPE:
262 DCHECK(!map->is_undetectable()); 275 DCHECK(!map->is_undetectable());
263 return kFunction; 276 return kFunction;
264 case JS_PROXY_TYPE: 277 case JS_PROXY_TYPE:
265 DCHECK(!map->is_undetectable()); 278 DCHECK(!map->is_undetectable());
266 return kProxy; 279 if (map->is_callable()) return kCallableProxy;
280 return kOtherProxy;
267 case MAP_TYPE: 281 case MAP_TYPE:
268 case ALLOCATION_SITE_TYPE: 282 case ALLOCATION_SITE_TYPE:
269 case ACCESSOR_INFO_TYPE: 283 case ACCESSOR_INFO_TYPE:
270 case SHARED_FUNCTION_INFO_TYPE: 284 case SHARED_FUNCTION_INFO_TYPE:
271 case FUNCTION_TEMPLATE_INFO_TYPE: 285 case FUNCTION_TEMPLATE_INFO_TYPE:
272 case ACCESSOR_PAIR_TYPE: 286 case ACCESSOR_PAIR_TYPE:
273 case FIXED_ARRAY_TYPE: 287 case FIXED_ARRAY_TYPE:
274 case FIXED_DOUBLE_ARRAY_TYPE: 288 case FIXED_DOUBLE_ARRAY_TYPE:
275 case BYTE_ARRAY_TYPE: 289 case BYTE_ARRAY_TYPE:
276 case BYTECODE_ARRAY_TYPE: 290 case BYTECODE_ARRAY_TYPE:
(...skipping 771 matching lines...) Expand 10 before | Expand all | Expand 10 after
1048 return i::SmiValuesAre31Bits() ? kSigned31 : kSigned32; 1062 return i::SmiValuesAre31Bits() ? kSigned31 : kSigned32;
1049 } 1063 }
1050 1064
1051 BitsetType::bitset BitsetType::UnsignedSmall() { 1065 BitsetType::bitset BitsetType::UnsignedSmall() {
1052 return i::SmiValuesAre31Bits() ? kUnsigned30 : kUnsigned31; 1066 return i::SmiValuesAre31Bits() ? kUnsigned30 : kUnsigned31;
1053 } 1067 }
1054 1068
1055 } // namespace compiler 1069 } // namespace compiler
1056 } // namespace internal 1070 } // namespace internal
1057 } // namespace v8 1071 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/types.h ('k') | src/runtime/runtime-test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698