Disable automatic retries of failing ANGLE tests.

Disable automatic retries of failing ANGLE tests.

This should prevent us from introducing flaky CLs, which is very bad.

BUG=669196
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/2027cd96349b99a5382364261a7c1386c1da3057
Cr-Commit-Position: refs/heads/master@{#435348}

[Jamie Madill, 2016-11-28 21:27:54]

Description was changed from

==========
Disable automatic retries of failing ANGLE tests.

This should prevent us from introducing flaky CLs, which is very bad.

BUG=669196
R=kbr@chromium.org
==========

to

==========
Disable automatic retries of failing ANGLE tests.

This should prevent us from introducing flaky CLs, which is very bad.

BUG=669196
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Jamie Madill, 2016-11-28 21:28:07]

The CQ bit was checked by jmadill@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 21:29:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 22:39:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 22:39:40]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Ken Russell (switch to Gerrit), 2016-11-29 02:53:45]

LGTM modulo adding comments.

https://codereview.chromium.org/2535753003/diff/1/content/test/gpu/generate_b...
File content/test/gpu/generate_buildbot_json.py (right):

https://codereview.chromium.org/2535753003/diff/1/content/test/gpu/generate_b...
content/test/gpu/generate_buildbot_json.py:806: 'args':
['--test-launcher-retry-limit=0'],
Please add a comment indicating that test retries are deliberately disabled for
this test suite and point to the bug ID.

https://codereview.chromium.org/2535753003/diff/1/content/test/gpu/generate_b...
content/test/gpu/generate_buildbot_json.py:815: 'args':
['--test-launcher-retry-limit=0'],
Same here.

[Jamie Madill, 2016-11-29 21:32:46]

On 2016/11/29 02:53:45, Ken Russell wrote:
> LGTM modulo adding comments.
> 
>
https://codereview.chromium.org/2535753003/diff/1/content/test/gpu/generate_b...
> File content/test/gpu/generate_buildbot_json.py (right):
> 
>
https://codereview.chromium.org/2535753003/diff/1/content/test/gpu/generate_b...
> content/test/gpu/generate_buildbot_json.py:806: 'args':
> ['--test-launcher-retry-limit=0'],
> Please add a comment indicating that test retries are deliberately disabled
for
> this test suite and point to the bug ID.
> 
>
https://codereview.chromium.org/2535753003/diff/1/content/test/gpu/generate_b...
> content/test/gpu/generate_buildbot_json.py:815: 'args':
> ['--test-launcher-retry-limit=0'],
> Same here.

Thanks Ken, added comment. Also disabled no Android, it doesn't seem to support
this flag. Will wait for the ANGLE roll with the necessary test suppressions
before landing.

[Jamie Madill, 2016-11-30 17:09:34]

The CQ bit was checked by jmadill@chromium.org

[Jamie Madill, 2016-11-30 17:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2535753003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-30 17:10:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 18:31:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480525774247650,
"parent_rev": "aa20a04ac6acd076770bcefff8f569aa8f062c3f", "commit_rev":
"319f95ab5634ad51269295261ffe5cec5b8ce3b8"}

[commit-bot: I haz the power, 2016-11-30 18:33:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 18:34:04]

Description was changed from

==========
Disable automatic retries of failing ANGLE tests.

This should prevent us from introducing flaky CLs, which is very bad.

BUG=669196
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Disable automatic retries of failing ANGLE tests.

This should prevent us from introducing flaky CLs, which is very bad.

BUG=669196
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/2027cd96349b99a5382364261a7c1386c1da3057
Cr-Commit-Position: refs/heads/master@{#435348}
==========

[commit-bot: I haz the power, 2016-11-30 18:34:05]

Patchset 3 (id:??) landed as
https://crrev.com/2027cd96349b99a5382364261a7c1386c1da3057
Cr-Commit-Position: refs/heads/master@{#435348}