Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 253573002: Avoid syncing chrome reference build and LayoutTests to speed up sync. (Closed)

Created:
6 years, 8 months ago by prasadv
Modified:
6 years, 8 months ago
Reviewers:
shatch, tonyg
CC:
chromium-reviews
Visibility:
Public.

Description

Avoid syncing chrome reference build and LayoutTests to speed up sync. Assuming this might also fix 'Out of Memory' issue on Windows bisect bot BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266311

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/bisect_utils.py View 1 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
prasadv
6 years, 8 months ago (2014-04-25 02:33:42 UTC) #1
tonyg
lgtm https://codereview.chromium.org/253573002/diff/1/tools/bisect_utils.py File tools/bisect_utils.py (right): https://codereview.chromium.org/253573002/diff/1/tools/bisect_utils.py#newcode44 tools/bisect_utils.py:44: "src/chrome/tools/test/reference_build/chrome_win": None, We should do the reference builds ...
6 years, 8 months ago (2014-04-25 02:37:27 UTC) #2
prasadv
https://codereview.chromium.org/253573002/diff/1/tools/bisect_utils.py File tools/bisect_utils.py (right): https://codereview.chromium.org/253573002/diff/1/tools/bisect_utils.py#newcode44 tools/bisect_utils.py:44: "src/chrome/tools/test/reference_build/chrome_win": None, On 2014/04/25 02:37:27, tonyg wrote: > We ...
6 years, 8 months ago (2014-04-25 17:09:32 UTC) #3
tonyg
lgtm https://codereview.chromium.org/253573002/diff/1/tools/bisect_utils.py File tools/bisect_utils.py (right): https://codereview.chromium.org/253573002/diff/1/tools/bisect_utils.py#newcode45 tools/bisect_utils.py:45: "src/third_party/WebKit/LayoutTests": None,} On 2014/04/25 17:09:33, prasadv wrote: > ...
6 years, 8 months ago (2014-04-25 17:16:21 UTC) #4
prasadv
On 2014/04/25 17:16:21, tonyg wrote: > lgtm > > https://codereview.chromium.org/253573002/diff/1/tools/bisect_utils.py > File tools/bisect_utils.py (right): > ...
6 years, 8 months ago (2014-04-25 17:23:48 UTC) #5
tonyg
> https://codereview.chromium.org/253573002/diff/20001/tools/bisect_utils.py#newcode44 > > tools/bisect_utils.py:44: "src/chrome/tools/test/reference_build/chrome_win": > > None, > > There's also a 64-bit ...
6 years, 8 months ago (2014-04-25 17:25:08 UTC) #6
shatch
On 2014/04/25 17:25:08, tonyg wrote: > > > https://codereview.chromium.org/253573002/diff/20001/tools/bisect_utils.py#newcode44 > > > tools/bisect_utils.py:44: > "src/chrome/tools/test/reference_build/chrome_win": ...
6 years, 8 months ago (2014-04-25 19:54:34 UTC) #7
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 8 months ago (2014-04-25 19:55:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/253573002/20001
6 years, 8 months ago (2014-04-25 22:08:06 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 00:48:58 UTC) #10
Message was sent while issue was closed.
Change committed as 266311

Powered by Google App Engine
This is Rietveld 408576698