Rename IFX_Stream to IFGAS_Stream.

Rename IFX_Stream to IFGAS_Stream.

It's a separate hierarchy unrelated to the IFX_*Stream classes.
Also rename CFX_Stream to CFGAS_Stream, and so forth.

Committed: https://pdfium.googlesource.com/pdfium/+/0527ec571a8842b84f5161dc67f8da439e65eb12

[Tom Sepez, 2016-12-01 23:48:47]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 23:48:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-01 23:54:38]

Description was changed from

==========
Rename IFX_Stream to IFGAS_Stream.

It's a separate hierarchy unrelated to the IFX_*Stream classes.
==========

to

==========
Rename IFX_Stream to IFGAS_Stream.

It's a separate hierarchy unrelated to the IFX_*Stream classes.
Also rename CFX_Stream to CFGAS_Stream.
==========

[Tom Sepez, 2016-12-01 23:55:07]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org

[Tom Sepez, 2016-12-01 23:55:20]

NPM, ready for review.

[Tom Sepez, 2016-12-02 00:00:42]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 00:00:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 00:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 00:13:55]

Dry run: This issue passed the CQ dry run.

[npm, 2016-12-02 16:23:22]

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
File xfa/fgas/crt/fgas_stream.cpp (right):

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:21: class IFX_StreamImp {
You probably want to rename all the classes in this namespace as well?

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:332: if (dwAccess & FX_STREAMACCESS_Text) {
Nit: {}

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:346: if (dwAccess & FX_STREAMACCESS_Text) {
Nitto

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:361: if (dwAccess & FX_STREAMACCESS_Text) {
Nitto

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:917: }
Nits: space needed between methods

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:1020: if (dwAccess & FX_STREAMACCESS_Text) {
{}

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:1454: return
IFGAS_Stream::CreateTextStream(pShared, true);
{}

[Tom Sepez, 2016-12-02 18:02:08]

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
File xfa/fgas/crt/fgas_stream.cpp (right):

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:21: class IFX_StreamImp {
On 2016/12/02 16:23:22, npm wrote:
> You probably want to rename all the classes in this namespace as well?

Good suggestion.

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:332: if (dwAccess & FX_STREAMACCESS_Text) {
On 2016/12/02 16:23:22, npm wrote:
> Nit: {}

Done.

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:346: if (dwAccess & FX_STREAMACCESS_Text) {
On 2016/12/02 16:23:22, npm wrote:
> Nitto

Done.

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:361: if (dwAccess & FX_STREAMACCESS_Text) {
On 2016/12/02 16:23:22, npm wrote:
> Nitto

Done.

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:917: }
On 2016/12/02 16:23:22, npm wrote:
> Nits: space needed between methods

Done.

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:1020: if (dwAccess & FX_STREAMACCESS_Text) {
On 2016/12/02 16:23:22, npm wrote:
> {}

Done.

https://codereview.chromium.org/2535723010/diff/60001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:1454: return
IFGAS_Stream::CreateTextStream(pShared, true);
On 2016/12/02 16:23:22, npm wrote:
> {}

Done.

[Tom Sepez, 2016-12-02 18:05:58]

Description was changed from

==========
Rename IFX_Stream to IFGAS_Stream.

It's a separate hierarchy unrelated to the IFX_*Stream classes.
Also rename CFX_Stream to CFGAS_Stream.
==========

to

==========
Rename IFX_Stream to IFGAS_Stream.

It's a separate hierarchy unrelated to the IFX_*Stream classes.
Also rename CFX_Stream to CFGAS_Stream, and so forth.
==========

[npm, 2016-12-02 18:26:25]

lgtm

[Tom Sepez, 2016-12-02 18:26:46]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-12-02 18:26:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 18:53:31]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480703206393590,
"parent_rev": "8b6a0a540563c6308fa03df34c90257e0bb65598", "commit_rev":
"0527ec571a8842b84f5161dc67f8da439e65eb12"}

[commit-bot: I haz the power, 2016-12-02 18:53:33]

Description was changed from

==========
Rename IFX_Stream to IFGAS_Stream.

It's a separate hierarchy unrelated to the IFX_*Stream classes.
Also rename CFX_Stream to CFGAS_Stream, and so forth.
==========

to

==========
Rename IFX_Stream to IFGAS_Stream.

It's a separate hierarchy unrelated to the IFX_*Stream classes.
Also rename CFX_Stream to CFGAS_Stream, and so forth.

Committed:
https://pdfium.googlesource.com/pdfium/+/0527ec571a8842b84f5161dc67f8da439e65...
==========

[commit-bot: I haz the power, 2016-12-02 18:53:34]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/0527ec571a8842b84f5161dc67f8da439e65...