Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: content/browser/loader/resource_scheduler_unittest.cc

Issue 2535723005: Stop using ResourceController in ResourceThrottle (Closed)
Patch Set: Addressed #62 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/resource_scheduler.cc ('k') | content/browser/loader/throttling_resource_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_scheduler_unittest.cc
diff --git a/content/browser/loader/resource_scheduler_unittest.cc b/content/browser/loader/resource_scheduler_unittest.cc
index cc40deabab4fe1fdb38a41633d0203475fd831e1..83c2b26853a320934338bd70bc06f6e93b4504de 100644
--- a/content/browser/loader/resource_scheduler_unittest.cc
+++ b/content/browser/loader/resource_scheduler_unittest.cc
@@ -14,7 +14,6 @@
#include "base/timer/mock_timer.h"
#include "base/timer/timer.h"
#include "content/public/browser/resource_context.h"
-#include "content/public/browser/resource_controller.h"
#include "content/public/browser/resource_throttle.h"
#include "content/public/test/mock_render_process_host.h"
#include "content/public/test/test_browser_context.h"
@@ -48,7 +47,7 @@ const int kBackgroundRouteId = 43;
const char kPrioritySupportedRequestsDelayable[] =
"PrioritySupportedRequestsDelayable";
-class TestRequest : public ResourceController {
+class TestRequest : public ResourceThrottle::Delegate {
public:
TestRequest(std::unique_ptr<net::URLRequest> url_request,
std::unique_ptr<ResourceThrottle> throttle,
@@ -57,7 +56,7 @@ class TestRequest : public ResourceController {
url_request_(std::move(url_request)),
throttle_(std::move(throttle)),
scheduler_(scheduler) {
- throttle_->set_controller_for_testing(this);
+ throttle_->set_delegate_for_testing(this);
}
~TestRequest() override {
// The URLRequest must still be valid when the ScheduledResourceRequest is
@@ -86,7 +85,7 @@ class TestRequest : public ResourceController {
const net::URLRequest* url_request() const { return url_request_.get(); }
protected:
- // ResourceController interface:
+ // ResourceThrottle::Delegate interface:
void CancelAndIgnore() override {}
void CancelWithError(int error_code) override {}
void Resume() override { started_ = true; }
« no previous file with comments | « content/browser/loader/resource_scheduler.cc ('k') | content/browser/loader/throttling_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698