Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2535723003: Add remoting_me2me_host as direct dependency of remoting_dev_me2me_host (Closed)

Created:
4 years ago by Sergey Ulanov
Modified:
4 years ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add remoting_me2me_host as direct dependency of remoting_dev_me2me_host Previously the host binary wasn't rebuilt when building remoting_dev_me2me_host. This CL adds direct dependency between these targets to avoid this problem. Committed: https://crrev.com/501ba9c41bf98743ccecc3f50c821f87520a1030 Cr-Commit-Position: refs/heads/master@{#434858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M remoting/host/linux/BUILD.gn View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sergey Ulanov
4 years ago (2016-11-29 00:38:06 UTC) #2
Lambros
lgtm
4 years ago (2016-11-29 01:12:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535723003/1
4 years ago (2016-11-29 01:14:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 03:06:30 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 03:11:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/501ba9c41bf98743ccecc3f50c821f87520a1030
Cr-Commit-Position: refs/heads/master@{#434858}

Powered by Google App Engine
This is Rietveld 408576698