Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2535713004: extensions: Cleanup class/struct fwd declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, jshin+watch_chromium.org, mac-reviews_chromium.org, stevenjb+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

extensions: Cleanup class/struct fwd declarations Remove useless class and struct forward declarations, and add missing ones in extensions header files. BUG=662195 Committed: https://crrev.com/12c9d49166df65545dd8cca1671891f048aea756 Cr-Commit-Position: refs/heads/master@{#434749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -237 lines) Patch
M extensions/browser/api/app_runtime/app_runtime_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_private_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_auth_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_socket.h View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_transport.h View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/browser/api/declarative/rules_registry_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_action.h View 2 chunks +0 lines, -7 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h View 2 chunks +0 lines, -8 lines 0 comments Download
M extensions/browser/api/extensions_api_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/api/hid/hid_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/management/management_api_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_delegate_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_event_router.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/printer_provider_internal/printer_provider_internal_api_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/socket/socket_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/usb/usb_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.h View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/browser/api/webcam_private/webcam_private_api.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/app_sorting.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/content_hash_fetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/event_listener_map.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/event_page_tracker.h View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/event_router.h View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/browser/extension_function.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/extension_host.h View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/browser/extension_icon_image.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_icon_placeholder.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_message_filter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/extension_navigation_throttle.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/extension_system.h View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/browser/extensions_test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/external_provider_interface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/extension_view/extension_view_guest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_content_script_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest_delegate.h View 1 chunk +0 lines, -7 lines 0 comments Download
M extensions/browser/sandboxed_unpacker.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/updater/extension_downloader_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/value_store/leveldb_value_store.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/value_store/value_store_frontend.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/warning_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/api/declarative/declarative_manifest_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/extension_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/extension_l10n_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/extensions_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/manifest_handlers/externally_connectable.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/permissions/api_permission_set.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/permissions/manifest_permission.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/permissions/manifest_permission_set.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/permissions/usb_device_permission.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/permissions/usb_device_permission_data.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/components/native_app_window/native_app_window_views.h View 1 chunk +0 lines, -11 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_transport_stream_packetizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/app_window_custom_bindings.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/content_watcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/renderer/dispatcher.h View 2 chunks +0 lines, -9 lines 0 comments Download
M extensions/renderer/dom_activity_logger.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/extensions_renderer_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/lazy_background_page_native_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/renderer/script_context_set.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/script_injection_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/script_injector.h View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/renderer/v8_context_native_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/renderer/worker_thread_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/app/paths_mac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/shell/app/shell_main_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/shell/browser/desktop_controller.h View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/shell/browser/shell_browser_context.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_url_request_context_getter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/test/shell_test.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/test/background_page_watcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/utility/unpacker.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jbriance
4 years ago (2016-11-28 15:52:57 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years ago (2016-11-28 20:09:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535713004/1
4 years ago (2016-11-28 22:28:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 22:46:21 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 22:50:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12c9d49166df65545dd8cca1671891f048aea756
Cr-Commit-Position: refs/heads/master@{#434749}

Powered by Google App Engine
This is Rietveld 408576698