Fix crash in CFDE_CSSSyntaxParser when parsing empty url

Fix crash in CFDE_CSSSyntaxParser when parsing empty url

When parsing "url('')", Subtract() should be called to correctly set
m_iDatLen. But iLength will be 0 because there is no url. So I changed
the ASSERT. Also replaced some non-const refs with pointers to make the
code more readable.

BUG=659509
Committed: https://pdfium.googlesource.com/pdfium/+/239915200225fea4c5a02e9630044ef13fccb66d

[npm, 2016-11-28 19:11:26]

Description was changed from

==========
Fix crash in CFDE_CSSSyntaxParser when parsing empty url

When parsing "url('')", Subtract() should be called to correctly set
m_iDatLen. But iLength will be 0 because there is no url. So I changed
the ASSERT. Also replaced some non-const refs with pointers to make the
code more readable.

BUG=659509
==========

to

==========
Fix crash in CFDE_CSSSyntaxParser when parsing empty url

When parsing "url('')", Subtract() should be called to correctly set
m_iDatLen. But iLength will be 0 because there is no url. So I changed
the ASSERT. Also replaced some non-const refs with pointers to make the
code more readable.

BUG=659509
==========

[npm, 2016-11-28 19:11:26]

npm@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[npm, 2016-11-28 19:11:33]

ptal

[Tom Sepez, 2016-11-28 19:24:40]

lgtm

https://codereview.chromium.org/2535663003/diff/1/xfa/fde/css/fde_cssdatatabl...
File xfa/fde/css/fde_cssdatatable.cpp (right):

https://codereview.chromium.org/2535663003/diff/1/xfa/fde/css/fde_cssdatatabl...
xfa/fde/css/fde_cssdatatable.cpp:709: *iOffset = 1, *iLength -= 2;
keep {} use ; not , and one per line.

https://codereview.chromium.org/2535663003/diff/1/xfa/fde/css/fde_csssyntax.cpp
File xfa/fde/css/fde_csssyntax.cpp (right):

https://codereview.chromium.org/2535663003/diff/1/xfa/fde/css/fde_csssyntax.c...
xfa/fde/css/fde_csssyntax.cpp:291: else
nit: else after return not needed.

[npm, 2016-11-28 20:35:45]

https://codereview.chromium.org/2535663003/diff/1/xfa/fde/css/fde_cssdatatabl...
File xfa/fde/css/fde_cssdatatable.cpp (right):

https://codereview.chromium.org/2535663003/diff/1/xfa/fde/css/fde_cssdatatabl...
xfa/fde/css/fde_cssdatatable.cpp:709: *iOffset = 1, *iLength -= 2;
On 2016/11/28 19:24:40, Tom Sepez wrote:
> keep {} use ; not , and one per line.

Done.

https://codereview.chromium.org/2535663003/diff/1/xfa/fde/css/fde_csssyntax.cpp
File xfa/fde/css/fde_csssyntax.cpp (right):

https://codereview.chromium.org/2535663003/diff/1/xfa/fde/css/fde_csssyntax.c...
xfa/fde/css/fde_csssyntax.cpp:291: else
On 2016/11/28 19:24:40, Tom Sepez wrote:
> nit: else after return not needed.

Done.

[npm, 2016-11-28 20:36:07]

The CQ bit was checked by npm@chromium.org

[npm, 2016-11-28 20:36:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2535663003/#ps20001
(title: "Comments")

[commit-bot: I haz the power, 2016-11-28 20:36:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 20:49:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480365367077650,
"parent_rev": "eb9625c04876c45862fb30e48a4fd6d5998db0e9", "commit_rev":
"239915200225fea4c5a02e9630044ef13fccb66d"}

[commit-bot: I haz the power, 2016-11-28 20:49:31]

Description was changed from

==========
Fix crash in CFDE_CSSSyntaxParser when parsing empty url

When parsing "url('')", Subtract() should be called to correctly set
m_iDatLen. But iLength will be 0 because there is no url. So I changed
the ASSERT. Also replaced some non-const refs with pointers to make the
code more readable.

BUG=659509
==========

to

==========
Fix crash in CFDE_CSSSyntaxParser when parsing empty url

When parsing "url('')", Subtract() should be called to correctly set
m_iDatLen. But iLength will be 0 because there is no url. So I changed
the ASSERT. Also replaced some non-const refs with pointers to make the
code more readable.

BUG=659509

Committed:
https://pdfium.googlesource.com/pdfium/+/239915200225fea4c5a02e9630044ef13fcc...
==========

[commit-bot: I haz the power, 2016-11-28 20:49:32]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/239915200225fea4c5a02e9630044ef13fcc...