Removed ordering dependencies for EListStyleType

Removed ordering dependencies for EListStyleType

Removed ordering dependencies for EListStyleType from
CSSValueKeywords.h. This was already done in crrev.com/2367293002, so
this patch just updates the comments to show it is no longer needed.

Also added a comment to clarify that the fast paths still rely on the
ordering, so not to update those.

BUG=665272
Committed: https://crrev.com/02bf8ffd9e09a701ca30410df5e1b71d37b0dd09
Cr-Commit-Position: refs/heads/master@{#435192}

[sashab, 2016-11-28 03:12:30]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org

[sashab, 2016-11-28 03:12:30]

Same as other ones

[alancutter (OOO until 2018), 2016-11-28 06:44:01]

Link to the "previous patch" in the description.

lgtm after comment change.

https://codereview.chromium.org/2535663002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyleConstants.h (right):

https://codereview.chromium.org/2535663002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyleConstants.h:271: //
CSSParserFastPaths as well.
What must be updated?

This should probably be worded as "The order of this enum must match the order
found in CSSParserFastPaths::someFunction()." to make it clearer what the
constraint is.

[sashab, 2016-11-30 00:11:05]

Yup, thanks for the rewording. Please re-review since I actually put the warning
in the wrong place - it goes in CSSValueKeywords.in since this generates the
CSSValues used in the parser (the parser doesn't use the enums). Will update the
comments removed by the previous patches on this bug.

[alancutter (OOO until 2018), 2016-11-30 00:14:16]

On 2016/11/30 at 00:11:05, sashab wrote:
> Yup, thanks for the rewording. Please re-review since I actually put the
warning in the wrong place - it goes in CSSValueKeywords.in since this generates
the CSSValues used in the parser (the parser doesn't use the enums). Will update
the comments removed by the previous patches on this bug.

The new patch doesn't appear to be uploaded.

[sashab, 2016-11-30 00:33:10]

Oops, here we go

[alancutter (OOO until 2018), 2016-11-30 00:35:52]

lgtm

[sashab, 2016-11-30 00:39:55]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-11-30 00:41:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-11-30 01:06:19]

Description was changed from

==========
Removed ordering dependencies for EListStyleType

Removed ordering dependencies for EListStyleType from
CSSValueKeywords.h. This was already done in a previous patch, so this
patch just updates the comments to show it is no longer needed.

Also added a comment to clarify that the fast paths still rely on the
ordering, so not to update those.

BUG=665272
==========

to

==========
Removed ordering dependencies for EListStyleType

Removed ordering dependencies for EListStyleType from
CSSValueKeywords.h. This was already done in crrev.com/2367293002, so
this patch just updates the comments to show it is no longer needed.

Also added a comment to clarify that the fast paths still rely on the
ordering, so not to update those.

BUG=665272
==========

[commit-bot: I haz the power, 2016-11-30 02:43:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 02:43:11]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[sashab, 2016-11-30 07:20:03]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-11-30 07:20:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2535663002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-30 07:20:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 09:08:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480490403003670,
"parent_rev": "a271477541441ac0f6eaec8fa85eacefce7593f0", "commit_rev":
"0096898b1dd0ef1b2c1e60b7ece42093e4501d44"}

[commit-bot: I haz the power, 2016-11-30 09:08:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 09:10:34]

Description was changed from

==========
Removed ordering dependencies for EListStyleType

Removed ordering dependencies for EListStyleType from
CSSValueKeywords.h. This was already done in crrev.com/2367293002, so
this patch just updates the comments to show it is no longer needed.

Also added a comment to clarify that the fast paths still rely on the
ordering, so not to update those.

BUG=665272
==========

to

==========
Removed ordering dependencies for EListStyleType

Removed ordering dependencies for EListStyleType from
CSSValueKeywords.h. This was already done in crrev.com/2367293002, so
this patch just updates the comments to show it is no longer needed.

Also added a comment to clarify that the fast paths still rely on the
ordering, so not to update those.

BUG=665272

Committed: https://crrev.com/02bf8ffd9e09a701ca30410df5e1b71d37b0dd09
Cr-Commit-Position: refs/heads/master@{#435192}
==========

[commit-bot: I haz the power, 2016-11-30 09:10:35]

Patchset 3 (id:??) landed as
https://crrev.com/02bf8ffd9e09a701ca30410df5e1b71d37b0dd09
Cr-Commit-Position: refs/heads/master@{#435192}