Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2535653002: Worker: Deprecate PostTaskToMainExecutionContext (Closed)

Created:
4 years ago by nhiroki
Modified:
4 years ago
Reviewers:
haraken, falken
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Deprecate PostTaskToMainExecutionContext This CL deprecates PostTaskToMainExecutionContext on InProcessWorkerObjectProxy and ThreadedWorkletObjectProxy in favor of per-frame task runners. This is a part of the project to migrate to per-frame scheduler. A general design doc about the project is available here: https://docs.google.com/document/d/10It1DFRP7H3gev9hQA-7dtTcvcMFhrxuCt3-k21yjgQ/edit?usp=sharing This CL also moves UseCounter::count and UseCounter::countDeprecation calls from DedicatedWorkerGlobalScope to ThreadedMessagingProxyBase because (1) per-frame task runners don't provide an execution context to a posted task like ExecutionContextTask (PostTaskToMainExecutionContext) and need an alternative way to get it, and (2) communications between the main thread and worker threads should be consolidated to MessaginProxy and ObjectProxy. BONUS: This cleanup makes it easier to share UseCounter code among workers and worklets. BUG=376039, 657694, 667310, 667357 Committed: https://crrev.com/6a8002607cc8e991e382adb29c7c5f13ee55da58 Cr-Commit-Position: refs/heads/master@{#434607}

Patch Set 1 #

Messages

Total messages: 19 (13 generated)
nhiroki
PTAL, thanks!
4 years ago (2016-11-28 03:50:41 UTC) #9
falken
lgtm
4 years ago (2016-11-28 04:04:11 UTC) #10
haraken
LGTM
4 years ago (2016-11-28 04:10:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535653002/20001
4 years ago (2016-11-28 05:16:48 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-11-28 05:23:46 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-28 05:26:20 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a8002607cc8e991e382adb29c7c5f13ee55da58
Cr-Commit-Position: refs/heads/master@{#434607}

Powered by Google App Engine
This is Rietveld 408576698