Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2535603002: Add CheckedNumeric::AssignIfValid() method (Closed)

Created:
4 years ago by jschuh
Modified:
4 years ago
Reviewers:
scottmg
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CheckedNumeric::AssignIfValid() method Helper for safely testing and extracting the underlying value. BUG=668713 Committed: https://crrev.com/e17e0f13e7c600c813674aca0265021da82b7f02 Cr-Commit-Position: refs/heads/master@{#434564}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M base/numerics/safe_math.h View 3 chunks +17 lines, -6 lines 1 comment Download
M base/numerics/safe_numerics_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
scottmg
lgtm https://codereview.chromium.org/2535603002/diff/1/base/numerics/safe_math.h File base/numerics/safe_math.h (right): https://codereview.chromium.org/2535603002/diff/1/base/numerics/safe_math.h#newcode46 base/numerics/safe_math.h:46: // pointer if the value is currently valid ...
4 years ago (2016-11-25 23:47:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535603002/1
4 years ago (2016-11-25 23:50:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-26 03:00:46 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e17e0f13e7c600c813674aca0265021da82b7f02 Cr-Commit-Position: refs/heads/master@{#434564}
4 years ago (2016-11-26 03:03:48 UTC) #8
scottmg
4 years ago (2016-11-26 05:43:01 UTC) #9
Message was sent while issue was closed.
On 2016/11/26 03:03:48, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/e17e0f13e7c600c813674aca0265021da82b7f02
> Cr-Commit-Position: refs/heads/master@{#434564}

lgtm with a comment means you should address the comment. :p

Powered by Google App Engine
This is Rietveld 408576698