Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2535543002: MacViews: Fix BrowserViewTest.RepeatedAccelerators. (Closed)

Created:
4 years ago by themblsha
Modified:
4 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix BrowserViewTest.RepeatedAccelerators. crbug.com/620315 unified Cocoa and Views accelerators, removing almost all Ctrl-accelerators from MacViews in the process. We must use Cmd+L in order to focus Omnibox on Mac. BUG=620315 Committed: https://crrev.com/23052ba5652db0942cb1b014314be33a5d372171 Cr-Commit-Position: refs/heads/master@{#434574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/ui/views/frame/browser_view_unittest.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
themblsha
4 years ago (2016-11-25 16:51:22 UTC) #2
Peter Kasting
LGTM, but it seems like the "if Mac COMMAND, else CONTROL" is a theme. Consider ...
4 years ago (2016-11-26 06:05:45 UTC) #4
themblsha
On 2016/11/26 06:05:45, Peter Kasting wrote: > LGTM, but it seems like the "if Mac ...
4 years ago (2016-11-26 14:43:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535543002/1
4 years ago (2016-11-26 14:43:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-26 17:05:32 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-26 17:07:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23052ba5652db0942cb1b014314be33a5d372171
Cr-Commit-Position: refs/heads/master@{#434574}

Powered by Google App Engine
This is Rietveld 408576698