Reduce webkit CSS prefixes in ui/ styles

Reduce webkit CSS prefixes in ui/ styles

Animations, transitions and transforms no longer require webkit prefix.

BUG=668650
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[Eric Willigers, 2016-11-25 10:14:05]

Description was changed from

==========
Reduce webkit prefixes in ui/ styles

Animations, transitions and transforms no longer require webkit prefix.

BUG=668650
==========

to

==========
Reduce webkit prefixes in ui/ styles

Animations, transitions and transforms no longer require webkit prefix.

BUG=668650
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Eric Willigers, 2016-11-25 10:19:39]

ericwilligers@chromium.org changed reviewers:
+ thakis@chromium.org

[Eric Willigers, 2016-11-25 10:19:40]

This CL was generated using the same sed commands I used to generate the
crbug.com/667644 changes.

[Eric Willigers, 2016-11-25 19:03:38]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 19:03:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 21:54:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 21:54:51]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-11-29 02:00:38]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-11-29 02:00:39]

did you look for CSSOM uses?  i.e. node.style.WebkitTransition

[Eric Willigers, 2016-11-29 04:21:39]

Patchset #1 (id:1) has been deleted

[Eric Willigers, 2016-11-29 05:30:54]

Patchset #2 (id:40001) has been deleted

[Eric Willigers, 2016-11-29 05:35:38]

On 2016/11/29 02:00:39, Dan Beam wrote:
> did you look for CSSOM uses?  i.e. node.style.WebkitTransition

Done.

[Dan Beam, 2016-11-29 06:17:12]

you get the picture on the alpha / indent nits...

https://codereview.chromium.org/2535493002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html
(right):

https://codereview.chromium.org/2535493002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html:51:
animation: ellipsis steps(4,end) 900ms infinite;
can you just remove this line?

https://codereview.chromium.org/2535493002/diff/60001/ui/file_manager/gallery...
File ui/file_manager/gallery/css/gallery.css (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/file_manager/gallery...
ui/file_manager/gallery/css/gallery.css:480: transition: opacity 500ms ease-in;
alphabetize

https://codereview.chromium.org/2535493002/diff/60001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.css (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.css:8: height 180ms ease;
does this fit in one line now?  either way, indent now off

https://codereview.chromium.org/2535493002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.css:62: transition: opacity 1s;
alpha

https://codereview.chromium.org/2535493002/diff/60001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.css (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.css:299: visibility 200ms ease-in-out;
indent off

https://codereview.chromium.org/2535493002/diff/60001/ui/login/bubble.css
File ui/login/bubble.css (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/login/bubble.css#new...
ui/login/bubble.css:9: transition: opacity 200ms ease-in-out;
alphabetize

https://codereview.chromium.org/2535493002/diff/60001/ui/login/oobe.css
File ui/login/oobe.css (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/login/oobe.css#newco...
ui/login/oobe.css:39: transition: border-color 200ms;
alpha

https://codereview.chromium.org/2535493002/diff/60001/ui/login/oobe.css#newco...
ui/login/oobe.css:146: transition: all 500ms linear;
alpha

https://codereview.chromium.org/2535493002/diff/60001/ui/login/oobe.css#newco...
ui/login/oobe.css:158: transition: 700ms opacity;
alpha

https://codereview.chromium.org/2535493002/diff/60001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/card_slider.js (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/card_slider.js:336: ontransitionend_: function(e) {
onTransitionEnd_

[Nico, 2016-11-29 16:55:10]

nice! lgtm once dbeam is happy.

Maybe mention "css" in the cl description somewhere; I expected this to be some
namespace reshuffling in cc files from the cl description.

[Eric Willigers, 2016-11-30 04:04:56]

https://codereview.chromium.org/2535493002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html
(right):

https://codereview.chromium.org/2535493002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html:51:
animation: ellipsis steps(4,end) 900ms infinite;
On 2016/11/29 06:17:12, Dan Beam wrote:
> can you just remove this line?

Done.

https://codereview.chromium.org/2535493002/diff/60001/ui/file_manager/gallery...
File ui/file_manager/gallery/css/gallery.css (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/file_manager/gallery...
ui/file_manager/gallery/css/gallery.css:480: transition: opacity 500ms ease-in;
On 2016/11/29 06:17:12, Dan Beam wrote:
> alphabetize

Done.

https://codereview.chromium.org/2535493002/diff/60001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.css (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.css:8: height 180ms ease;
On 2016/11/29 06:17:12, Dan Beam wrote:
> does this fit in one line now?  either way, indent now off

Done.

https://codereview.chromium.org/2535493002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.css:62: transition: opacity 1s;
On 2016/11/29 06:17:12, Dan Beam wrote:
> alpha

Done.

https://codereview.chromium.org/2535493002/diff/60001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.css (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.css:299: visibility 200ms ease-in-out;
On 2016/11/29 06:17:12, Dan Beam wrote:
> indent off

Done.

https://codereview.chromium.org/2535493002/diff/60001/ui/login/bubble.css
File ui/login/bubble.css (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/login/bubble.css#new...
ui/login/bubble.css:9: transition: opacity 200ms ease-in-out;
On 2016/11/29 06:17:12, Dan Beam wrote:
> alphabetize

Done.

https://codereview.chromium.org/2535493002/diff/60001/ui/login/oobe.css
File ui/login/oobe.css (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/login/oobe.css#newco...
ui/login/oobe.css:39: transition: border-color 200ms;
On 2016/11/29 06:17:12, Dan Beam wrote:
> alpha

Done.

https://codereview.chromium.org/2535493002/diff/60001/ui/login/oobe.css#newco...
ui/login/oobe.css:146: transition: all 500ms linear;
On 2016/11/29 06:17:12, Dan Beam wrote:
> alpha

Done.

https://codereview.chromium.org/2535493002/diff/60001/ui/login/oobe.css#newco...
ui/login/oobe.css:158: transition: 700ms opacity;
On 2016/11/29 06:17:12, Dan Beam wrote:
> alpha

Done.

https://codereview.chromium.org/2535493002/diff/60001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/card_slider.js (right):

https://codereview.chromium.org/2535493002/diff/60001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/card_slider.js:336: ontransitionend_: function(e) {
On 2016/11/29 06:17:12, Dan Beam wrote:
> onTransitionEnd_

Done.

https://codereview.chromium.org/2535493002/diff/120001/ui/webui/resources/css...
File ui/webui/resources/css/overlay.css (right):

https://codereview.chromium.org/2535493002/diff/120001/ui/webui/resources/css...
ui/webui/resources/css/overlay.css:16: /* TODO(dbeam): remove perspective when
http://crbug.com/374970 is fixed. */
BTW, we now have "will-change: transform;" - see http://crbug.com/600867

[Eric Willigers, 2016-11-30 11:19:01]

Description was changed from

==========
Reduce webkit prefixes in ui/ styles

Animations, transitions and transforms no longer require webkit prefix.

BUG=668650
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Reduce webkit CSS prefixes in ui/ styles

Animations, transitions and transforms no longer require webkit prefix.

BUG=668650
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-01 00:22:43]

lgtm

https://codereview.chromium.org/2535493002/diff/120001/ui/webui/resources/css...
File ui/webui/resources/css/overlay.css (right):

https://codereview.chromium.org/2535493002/diff/120001/ui/webui/resources/css...
ui/webui/resources/css/overlay.css:16: /* TODO(dbeam): remove perspective when
http://crbug.com/374970 is fixed. */
On 2016/11/30 04:04:56, Eric Willigers wrote:
> BTW, we now have "will-change: transform;" - see http://crbug.com/600867

Acknowledged.

https://codereview.chromium.org/2535493002/diff/120001/ui/webui/resources/css...
File ui/webui/resources/css/widgets.css (right):

https://codereview.chromium.org/2535493002/diff/120001/ui/webui/resources/css...
ui/webui/resources/css/widgets.css:238: transition: border-color 200ms;
nit: move to bottom

[Eric Willigers, 2016-12-02 11:24:00]

https://codereview.chromium.org/2535493002/diff/120001/ui/webui/resources/css...
File ui/webui/resources/css/widgets.css (right):

https://codereview.chromium.org/2535493002/diff/120001/ui/webui/resources/css...
ui/webui/resources/css/widgets.css:238: transition: border-color 200ms;
On 2016/12/01 00:22:42, Dan Beam wrote:
> nit: move to bottom

Done.

[Eric Willigers, 2016-12-02 11:24:13]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-12-02 11:24:14]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2535493002/#ps140001
(title: "sort")

[commit-bot: I haz the power, 2016-12-02 11:24:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 12:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 12:38:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2016-12-02 14:49:20]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-12-02 14:49:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 16:05:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 16:05:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2016-12-02 16:08:13]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-12-02 16:08:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 17:52:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 17:52:41]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2016-12-14 04:04:22]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 04:04:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 05:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 05:41:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2017-02-07 21:59:43]

so, what's up with this CL?

[Eric Willigers, 2017-02-09 03:58:42]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 03:59:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 04:03:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 04:03:27]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eric Willigers, 2017-02-09 04:16:29]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 04:17:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 05:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 05:13:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eric Willigers, 2017-02-10 02:55:55]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 02:56:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-02-10 02:59:01]

On 2017/02/07 21:59:43, Dan Beam wrote:
> so, what's up with this CL?

BluetoothInternalsTest.Startup_BluetoothInternals failed because
chrome/browser/resources/bluetooth_internals/snackbar.js was still expecting
webkitTransitionEnd
but ensureTransitionEndEvent in ui/webui/resources/js/util.js was now
dispatching transitionend events.

Adding chrome/browser/resources/bluetooth_internals/snackbar.js update to this
CL.

[commit-bot: I haz the power, 2017-02-10 03:10:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 03:10:12]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2017-02-10 05:13:34]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-02-10 05:13:35]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2535493002/#ps220001
(title: "bluetooth_internals/snackbar.js")

[commit-bot: I haz the power, 2017-02-10 05:14:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 06:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 06:02:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2017-02-15 06:48:56]

The transforms and animations changes have landed.

The transitions changes have been included in
https://codereview.chromium.org/2691883002/

[Eric Willigers, 2017-02-20 02:17:56]

Landed as
https://codereview.chromium.org/2693793002/
https://codereview.chromium.org/2692803003/
https://codereview.chromium.org/2691883002/