Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Unified Diff: chrome/browser/engagement/site_engagement_helper.h

Issue 2535483002: Plumb site engagement to the renderer process. (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_helper.h
diff --git a/chrome/browser/engagement/site_engagement_helper.h b/chrome/browser/engagement/site_engagement_helper.h
index 134f5f00de6dfa8a46fd91134a99eaf7a61548b3..7518e8f6412cb255bee3c17b8e23582f3f3f44b2 100644
--- a/chrome/browser/engagement/site_engagement_helper.h
+++ b/chrome/browser/engagement/site_engagement_helper.h
@@ -11,10 +11,16 @@
#include "chrome/browser/engagement/site_engagement_service.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
+#include "third_party/WebKit/public/platform/site_engagement.mojom.h"
+
+class GURL;
namespace content {
class NavigationHandle;
-class WebContents;
+}
+
+namespace url {
+class Origin;
}
// Per-WebContents class to handle updating the site engagement scores for
@@ -23,12 +29,15 @@ class SiteEngagementService::Helper
: public content::WebContentsObserver,
public content::WebContentsUserData<SiteEngagementService::Helper> {
public:
- ~Helper() override;
-
static void SetSecondsBetweenUserInputCheck(int seconds);
static void SetSecondsTrackingDelayAfterNavigation(int seconds);
static void SetSecondsTrackingDelayAfterShow(int seconds);
+ ~Helper() override;
+
+ void OnEngagementLevelChanged(const GURL& url,
+ blink::mojom::EngagementLevel level);
+
private:
// Class to encapsulate the periodic detection of site engagement.
//
@@ -160,8 +169,17 @@ class SiteEngagementService::Helper
// current WebContents URL.
void RecordMediaPlaying(bool is_hidden);
+ void SendEngagementLevelToFramesMatchingOrigin(
+ const url::Origin& origin,
+ blink::mojom::EngagementLevel level,
+ content::RenderFrameHost* render_frame_host);
+ void SendEngagementLevelToFrame(const url::Origin& origin,
+ blink::mojom::EngagementLevel level,
+ content::RenderFrameHost* render_frame_host);
+
// content::WebContentsObserver overrides.
void DidFinishNavigation(content::NavigationHandle* handle) override;
+ void ReadyToCommitNavigation(content::NavigationHandle* handle) override;
void WasShown() override;
void WasHidden() override;

Powered by Google App Engine
This is Rietveld 408576698