third_party/WebKit/public/platform/site_engagement.mojom - Issue 2535483002: Plumb site engagement to the renderer process.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/site_engagement.mojom

Issue 2535483002: Plumb site engagement to the renderer process. (Closed)

Patch Set: Address comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module blink.mojom;

	6

	7 import "url/mojo/origin.mojom";

	8

	9 enum EngagementLevel {

	10 NONE,

	11 MINIMAL,

	12 LOW,

	13 MEDIUM,

	14 HIGH,

	15 MAX,

	16 };

	17

	18 interface EngagementClient {

	19 // The browser tells the renderer the engagement level of the current URL.
	nasko 2016/11/30 18:00:25 nit: Let's avoid using the word "current" as it is nit: Let's avoid using the word "current" as it is not very clear. Also, this API can probably be called with arbitrary origin, so there is no enforcement that the origin is the current one. Last, the parameter is an origin, not an URL :). dominickn 2016/11/30 23:46:33 Done. Show quoted text On 2016/11/30 18:00:25, nasko wrote: > nit: Let's avoid using the word "current" as it is not very clear. Also, this > API can probably be called with arbitrary origin, so there is no enforcement > that the origin is the current one. Last, the parameter is an origin, not an URL > :). Done.
	20 SetEngagementLevel(url.mojom.Origin origin, EngagementLevel level);

	21 };

OLD	NEW