third_party/WebKit/public/platform/site_engagement.mojom - Issue 2535483002: Plumb site engagement to the renderer process.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/site_engagement.mojom

Issue 2535483002: Plumb site engagement to the renderer process. (Closed)

Patch Set: Rebase. Fix Win compile Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module blink.mojom;

	6

	7 enum EngagementLevel {

	8 NONE,

	9 MINIMAL,

	10 LOW,

	11 MEDIUM,

	12 HIGH,

	13 MAX,

	14 };

	15

	16 interface EngagementClient {

	17 // The browser tells the renderer the engagement level of the current URL.

	18 SetEngagementLevel(EngagementLevel level);
	nasko 2016/11/28 19:18:08 I would suggest adding the URL as an explicit para I would suggest adding the URL as an explicit parameter, as navigations are inherently a racy part of the browser, so the idea of "current URL" can mismatch between processes. Having an explicit URL allows the receiver to verify it. The HostZoom level works in a similar way, if you are looking for equivalent feature. dominickn 2016/11/29 07:41:22 Done. Show quoted text On 2016/11/28 19:18:08, nasko wrote: > I would suggest adding the URL as an explicit parameter, as navigations are > inherently a racy part of the browser, so the idea of "current URL" can mismatch > between processes. > Having an explicit URL allows the receiver to verify it. The HostZoom level > works in a similar way, if you are looking for equivalent feature. Done.
	19 };

OLD	NEW