Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2535443002: Mac: Fix case of CoreMIDI.framework when building midi_unittests. (Closed)

Created:
4 years ago by tapted
Modified:
4 years ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix case of CoreMIDI.framework when building midi_unittests. It's currently CoreMidi, which causes a failure on `build all` when on a case-sensitive filesystem. BUG=668571 R=toyoshim@chromium.org Committed: https://crrev.com/7758f1009343fcb9d79eafc514ac2f86956c023b Cr-Commit-Position: refs/heads/master@{#434623}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/midi/BUILD.gn View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 12 (7 generated)
tapted
https://codereview.chromium.org/2535443002/diff/1/media/midi/BUILD.gn File media/midi/BUILD.gn (right): https://codereview.chromium.org/2535443002/diff/1/media/midi/BUILD.gn#newcode136 media/midi/BUILD.gn:136: "CoreMIDI.framework", (note it appears here as `MIDI`, just not ...
4 years ago (2016-11-25 00:51:29 UTC) #3
Takashi Toyoshima
Thank you for catching this. LGTM.
4 years ago (2016-11-25 09:55:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535443002/1
4 years ago (2016-11-28 07:37:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 09:23:08 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-28 09:24:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7758f1009343fcb9d79eafc514ac2f86956c023b
Cr-Commit-Position: refs/heads/master@{#434623}

Powered by Google App Engine
This is Rietveld 408576698