Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 2535403002: IME for Mus: Fix InputMethodMusTest.DispatchKeyEvent's deadlock. (Closed)

Created:
4 years ago by Hadi
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, tfarina, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IME for Mus: Fix InputMethodMusTest.DispatchKeyEvent's deadlock. What was happening was: - IMEServerImpl starts test_ime_driver, which registers itself to Mus. - InputMethodMusTests requests to start test_ime_driver, but before it starts, it connects to IMEServer, which creates a connection between client and the first test_ime_driver. - test_ime_driver starts for a 2nd time, which causes IMEServerImpl to drop the connection to the first test_ime_driver. This causes clients using the first test_ime_driver to hang. This fix: - Removes starting the test_ime_driver for a 2nd time. - Rejects drivers after first driver registers itself. BUG=668181 Committed: https://crrev.com/c2edfc8753717dee68567dbb08f04e8623f1be65 Cr-Commit-Position: refs/heads/master@{#435291}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M services/ui/ime/ime_server_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/mus/input_method_mus_unittest.cc View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
Hadi
PTAL.
4 years ago (2016-11-29 22:46:54 UTC) #8
sky
LGTM
4 years ago (2016-11-29 23:58:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535403002/40001
4 years ago (2016-11-30 00:12:07 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-30 00:48:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535403002/40001
4 years ago (2016-11-30 02:06:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535403002/60001
4 years ago (2016-11-30 15:38:28 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-30 16:45:34 UTC) #23
commit-bot: I haz the power
4 years ago (2016-11-30 16:50:14 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c2edfc8753717dee68567dbb08f04e8623f1be65
Cr-Commit-Position: refs/heads/master@{#435291}

Powered by Google App Engine
This is Rietveld 408576698