Issue 25354004: Allow sampling GIF images during decode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25354004: Allow sampling GIF images during decode. (Closed)

Created:
7 years, 2 months ago by scroggo

Modified:
7 years, 2 months ago

Reviewers:
hal.canary, djsollen, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Allow sampling GIF images during decode. SkScaledBitmapSampler: Add a mode for sampling rows out of order, used by GIF decoder for interlaced images. Add a getter for the X sampling rate. SkImageDecoder_libgif: Respect the sampleSize set on SkImageDecoder. skimage_main: Provide an option to set a sample size. BUG=https://b.corp.google.com/issue?id=8999690 Committed: http://code.google.com/p/skia/source/detail?r=11659

Patch Set 1 #

Patch Set 2 : Better variable name, handle opaque #

Patch Set 3 : Switch back to using kIndex8 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -39 lines)			Patch
M	src/images/SkImageDecoder_libgif.cpp	View	1 2	7 chunks	+95 lines, -38 lines	0 comments	Download
M	src/images/SkScaledBitmapSampler.h	View		3 chunks	+19 lines, -0 lines	0 comments	Download
M	src/images/SkScaledBitmapSampler.cpp	View	1	3 chunks	+27 lines, -0 lines	0 comments	Download
M	tools/skimage_main.cpp	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

scroggo

Latest patch goes back to using kIndex8. Please take another look.

7 years, 2 months ago (2013-10-08 14:16:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/25354004/12001

7 years, 2 months ago (2013-10-08 19:33:26 UTC) #5

Message was sent while issue was closed.

Change committed as 11659

Expand Messages | Collapse Messages