Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: tests/standalone/io/web_socket_pipe_test.dart

Issue 25354003: Redo StreamTransformers so they work with Stack traces. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/async/stream_transformer_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/web_socket_pipe_test.dart
diff --git a/tests/standalone/io/web_socket_pipe_test.dart b/tests/standalone/io/web_socket_pipe_test.dart
index e182a40389dfed0a2cd83c41b316fcac853dfa42..b487b7473bd6bc5aa7a4ccd69d65ac9d82e8ecf1 100644
--- a/tests/standalone/io/web_socket_pipe_test.dart
+++ b/tests/standalone/io/web_socket_pipe_test.dart
@@ -11,23 +11,20 @@ import "package:expect/expect.dart";
import "dart:async";
import "dart:io";
-class IdentityTransformer extends StreamEventTransformer {
- void handleData(data, sink) => sink.add(data);
-}
-
-class ReverseStringTransformer extends StreamEventTransformer {
- void handleData(String data, sink) {
- var sb = new StringBuffer();
- for (int i = data.length - 1; i >= 0; i--) sb.write(data[i]);
- sink.add(sb.toString());
- }
+createReverseStringTransformer() {
+ return new StreamTransformer.fromHandlers(
+ handleData: (String data, sink) {
+ var sb = new StringBuffer();
+ for (int i = data.length - 1; i >= 0; i--) sb.write(data[i]);
+ sink.add(sb.toString());
+ });
}
testPipe({int messages, bool transform}) {
HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen((request) {
WebSocketTransformer.upgrade(request).then((websocket) {
- (transform ? websocket.transform(new ReverseStringTransformer())
+ (transform ? websocket.transform(createReverseStringTransformer())
: websocket)
.pipe(websocket)
.then((_) => server.close());
« no previous file with comments | « tests/lib/async/stream_transformer_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698