Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: sdk/lib/async/stream_pipe.dart

Issue 25354003: Redo StreamTransformers so they work with Stack traces. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/stream_impl.dart ('k') | sdk/lib/async/stream_transformers.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/stream_pipe.dart
diff --git a/sdk/lib/async/stream_pipe.dart b/sdk/lib/async/stream_pipe.dart
index 3494de541e476f479cbdeec0d65e17f7d762fb93..fd85d170293d12b367346318dcbbe154b934ac93 100644
--- a/sdk/lib/async/stream_pipe.dart
+++ b/sdk/lib/async/stream_pipe.dart
@@ -400,64 +400,3 @@ class _DistinctStream<T> extends _ForwardingStream<T, T> {
}
}
}
-
-// Stream transformations and event transformations.
-
-typedef void _TransformDataHandler<S, T>(S data, EventSink<T> sink);
-typedef void _TransformErrorHandler<T>(Object error, EventSink<T> sink);
-typedef void _TransformDoneHandler<T>(EventSink<T> sink);
-
-/** Default data handler forwards all data. */
-void _defaultHandleData(var data, EventSink sink) {
- sink.add(data);
-}
-
-/** Default error handler forwards all errors. */
-void _defaultHandleError(error, EventSink sink) {
- sink.addError(error);
-}
-
-/** Default done handler forwards done. */
-void _defaultHandleDone(EventSink sink) {
- sink.close();
-}
-
-
-/**
- * A [StreamTransformer] that modifies stream events.
- *
- * This class is used by [StreamTransformer]'s factory constructor.
- * It is actually an [StreamEventTransformer] where the functions used to
- * modify the events are passed as constructor arguments.
- *
- * If an argument is omitted, it acts as the default method from
- * [StreamEventTransformer].
- */
-class _StreamTransformerImpl<S, T> extends StreamEventTransformer<S, T> {
- final _TransformDataHandler<S, T> _handleData;
- final _TransformErrorHandler<T> _handleError;
- final _TransformDoneHandler<T> _handleDone;
-
- _StreamTransformerImpl(void handleData(S data, EventSink<T> sink),
- void handleError(data, EventSink<T> sink),
- void handleDone(EventSink<T> sink))
- : this._handleData = (handleData == null ? _defaultHandleData
- : handleData),
- this._handleError = (handleError == null ? _defaultHandleError
- : handleError),
- this._handleDone = (handleDone == null ? _defaultHandleDone
- : handleDone);
-
- void handleData(S data, EventSink<T> sink) {
- _handleData(data, sink);
- }
-
- void handleError(error, EventSink<T> sink) {
- _handleError(error, sink);
- }
-
- void handleDone(EventSink<T> sink) {
- _handleDone(sink);
- }
-}
-
« no previous file with comments | « sdk/lib/async/stream_impl.dart ('k') | sdk/lib/async/stream_transformers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698