Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: pkg/barback/test/stream_pool_test.dart

Issue 25354003: Redo StreamTransformers so they work with Stack traces. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/http_server/lib/src/http_body_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/test/stream_pool_test.dart
diff --git a/pkg/barback/test/stream_pool_test.dart b/pkg/barback/test/stream_pool_test.dart
index d7013292cb42551de8a5467f5c47c6bfab2dfba5..fafa1f502cb52ffa4680f5256145b28a70037a40 100644
--- a/pkg/barback/test/stream_pool_test.dart
+++ b/pkg/barback/test/stream_pool_test.dart
@@ -50,9 +50,11 @@ main() {
controller1.add("fifth");
expect(newFuture(() {
- return pool.stream.transform(new StreamTransformer(
+ return pool.stream.transform(new StreamTransformer.fromHandlers(
handleData: (data, sink) => sink.add(["data", data]),
- handleError: (error, sink) => sink.add(["error", error]))).toList();
+ handleError: (error, stackTrace, sink) {
+ sink.add(["error", error]);
+ })).toList();
}), completion(equals([
["data", "first"],
["data", "second"],
@@ -111,9 +113,10 @@ main() {
controller2.addError("second");
expect(newFuture(() {
- return pool.stream.transform(new StreamTransformer(
+ return pool.stream.transform(new StreamTransformer.fromHandlers(
handleData: (data, sink) => sink.add(data),
- handleError: (error, sink) => sink.add(error))).toList();
+ handleError: (error, stackTrace, sink) { sink.add(error); }))
+ .toList();
}), completion(isEmpty));
pumpEventQueue().then((_) => pool.close());
« no previous file with comments | « no previous file | pkg/http_server/lib/src/http_body_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698