Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(286)

Issue 2535393004: DevTools: [SuggestBox] follow-up to migration icons to UI.Icon (Closed)

Created:
3 years, 8 months ago by lushnikov
Modified:
3 years, 8 months ago
Reviewers:
einbinder, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SuggestBox] follow-up to migration icons to UI.Icon Patch crrev.com/2534383002 introduced flexbox layout for suggestion items. However, it should also be more accurate with item flexing, which gets messed up in some rare cases. This patch wraps suggestion text in its own span so that it shrinks properly. BUG=669323 R=dgozman Committed: https://crrev.com/df15e0911044f80eb118b925b2a3e48288e453ef Cr-Commit-Position: refs/heads/master@{#435542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/suggestBox.css View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
lushnikov
please, take a look
3 years, 8 months ago (2016-12-01 01:33:16 UTC) #5
einbinder
On 2016/12/01 at 01:33:16, lushnikov wrote: > please, take a look Sometimes multiline suggestions get ...
3 years, 8 months ago (2016-12-01 02:36:15 UTC) #8
lushnikov
yes, it works the same. Thanks!
3 years, 8 months ago (2016-12-01 03:11:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535393004/1
3 years, 8 months ago (2016-12-01 03:12:16 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 8 months ago (2016-12-01 03:16:33 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2016-12-01 03:19:21 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df15e0911044f80eb118b925b2a3e48288e453ef
Cr-Commit-Position: refs/heads/master@{#435542}

Powered by Google App Engine
This is Rietveld 408576698